Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move device names storage from RAM buffer to EEPROM #205

Closed
GioCC opened this issue Oct 4, 2022 · 2 comments
Closed

Move device names storage from RAM buffer to EEPROM #205

GioCC opened this issue Oct 4, 2022 · 2 comments

Comments

@GioCC
Copy link
Contributor

GioCC commented Oct 4, 2022

Device names are currently copied to a RAM buffer when the configuration is loaded, and later retrieved from there when they have to be inserted in messages.
They could be retrieved directly from the EEPROM when required, allowing for 1500 bytes of RAM to be freed up with no penalty except a negligible increase of processing time.

(This issue could later become irrelevant if/when names will be removed from message content, but since that's still under scrutiny, until then it makes sense to benefit from not wasting memory.)

@GioCC GioCC self-assigned this Oct 4, 2022
GioCC added a commit to GioCC/MobiFlight-FirmwareSource that referenced this issue Oct 5, 2022
@GioCC GioCC removed their assignment Oct 8, 2022
@DocMoebiuz
Copy link
Collaborator

DocMoebiuz commented Oct 9, 2022

we decided we won't do this, but change the way how the messages are structured. I will create a new issue for that.
We want to send the device ID instead of the name.

@DocMoebiuz
Copy link
Collaborator

@elral had already created the issue: #207

GioCC added a commit to GioCC/MobiFlight-FirmwareSource that referenced this issue Oct 10, 2022
GioCC added a commit to GioCC/MobiFlight-FirmwareSource that referenced this issue Oct 10, 2022
GioCC added a commit to GioCC/MobiFlight-FirmwareSource that referenced this issue Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants