Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin 0 on RP2040 is not accepted as stepper auto-zero pin #1881

Open
tigert opened this issue Dec 18, 2024 · 0 comments
Open

pin 0 on RP2040 is not accepted as stepper auto-zero pin #1881

tigert opened this issue Dec 18, 2024 · 0 comments

Comments

@tigert
Copy link
Contributor

tigert commented Dec 18, 2024

Describe the bug
Steppers let you describe a pin for limit switch, so that mobiflight knows the zero point without manual calibration.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Click on Add stepper device in MF Modules and with your RP Pico selected
  2. Set the pins, and set auto zero switch to pin 0.
  3. Click on the board name and again the stepper device
  4. Observe the auto zero [x] None checkbox became checked again. This happens only on pin 0.

Expected behavior
Should allow all valid pins as auto zero pin.

"The Revelation", aka "oh crap..."
Actually the problem is not trivial to fix. We use "0" to mark "no auto-zero pin is set" it seems, because before RP2040 or ProMicro, GPIO 0 and 1 were never available since they are the USB serial port in most Arduinos.

So I guess there is a problem that setting it to zero, makes MF Connector assume the pin was unset, but even when it is saved to the eeprom, the firmware also interprets it as "no pin is set".

Details

  • MobiFlight Version: 10.4.0.1
  • FlightSim: irrelevant
  • AddOn: irrelevant

Additional context
Touches also MobiFlight-Firmware side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant