Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent WASM install when MSFS is running #1873

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Prevent WASM install when MSFS is running #1873

wants to merge 4 commits into from
+65 −29

Conversation

neilenns
Copy link
Contributor

Fixes #1872

Dialog looks like this:

image

It only appears if MSFS is the detected running sim, and will not show if the sim is closed.

@neilenns neilenns requested a review from DocMoebiuz as a code owner November 30, 2024 17:41
@github-actions GitHub Actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz
Copy link
Collaborator

@neilenns thanks! Can you please add German translation:

Das WASM Modul kann nicht installiert werden, solange Microsoft Flight Simulator läuft.

Schließe MSFS und versuche die Installation erneut.

@neilenns
Copy link
Contributor Author

@DocMoebiuz German string added

@github-actions GitHub Actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

@DocMoebiuz
Copy link
Collaborator

Is it clear to the user how to retry the install after the initial startup?

@neilenns
Copy link
Contributor Author

No more or less than it was before 😂 They have to go to the extras menu.

@DocMoebiuz
Copy link
Collaborator

DocMoebiuz commented Dec 16, 2024 •
edited
Loading

I mean, we could mention that in the dialog, right?

Close MSFS and install the WASM module via menu "Extras" > "Microsoft Flight Simulator" > "Install WASM module"

I think it is better to really provide the instructions for solving the problem.

@neilenns
Copy link
Contributor Author

Can you give me the German version?

@DocMoebiuz
Copy link
Collaborator

Schließe MSFS und führe die Installation erneut aus: "Extras" > "Microsoft Flight Simulator" > "Install WASM module"

DocMoebiuz
DocMoebiuz reviewed Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@DocMoebiuz DocMoebiuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. still missing the latest feedback :D got ahead of myself

@neilenns
Copy link
Contributor Author

@DocMoebiuz updated

@github-actions GitHub Actions
Copy link

Build for this pull request:
MobiFlightConnector.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DocMoebiuz DocMoebiuz DocMoebiuz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prevent WASM install if the sim is running
2 participants
@neilenns @DocMoebiuz