Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Improvements on SeeItSayItLabelEnabler (translation + auto-update) #593

Open
anonymous2585 opened this issue Dec 22, 2023 · 3 comments · May be fixed by #792
Open

[FEATURE REQUEST] Improvements on SeeItSayItLabelEnabler (translation + auto-update) #593

anonymous2585 opened this issue Dec 22, 2023 · 3 comments · May be fixed by #792
Assignees
Labels
Priority: Medium The priority of the issue is medium. Type: Feature Request A request for a new feature that can be included with the next minor version release.

Comments

@anonymous2585
Copy link
Contributor

Describe the problem

  1. The "See It Say It Label" doesn't support translations. We'd like the be able to customize the "Say '{keyword}'" pattern depending on the current user language (we use Unity Localization package).

  2. When changing the SpeechRecognitionKeyword of a StatefulInteractable, the label isn't updated automatically. It could be great if the MRTK handles it natively.

Describe the solution you'd like

  1. A translation compatibility with the Unity Localization package: if the package is installed, display a LocalizedString field in the inspector to allow to choose the pattern (using a smart string) for the keyword.

  2. Add SpeechRecognitionKeyword changed events in the StatefulInteractable and register the SeeItSayItLabelEnabler to it so it automatically update

@anonymous2585 anonymous2585 added Needs: Triage Needs to be triaged. Type: Feature Request A request for a new feature that can be included with the next minor version release. labels Dec 22, 2023
@AMollis AMollis removed the Needs: Triage Needs to be triaged. label Jan 2, 2024
@AMollis
Copy link
Contributor

AMollis commented Jan 2, 2024

Good idea. We welcome community contributions to the project. If you have a solution for this, please purpose to the project maintainers.

@AMollis AMollis added the Priority: Low The priority of the issue is low. label Jan 2, 2024
@AMollis
Copy link
Contributor

AMollis commented Jan 2, 2024

Hi @anonymous2585 ,

Thank you for reporting this issue or requesting this feature. We appreciate your feedback and interest in MRTK3.

We have reviewed your issue or feature request and confirmed that it is valid. We have added it to our backlog and will prioritize it accordingly.

However, if you would like to speed up the process and contribute to the MRTK3 project, you are welcome to submit a Pull Request with your proposed fix or implementation. We would be happy to review your code and merge it into the main branch if it meets our quality standards.

Please let us know if you have any questions or need any assistance. Thank you for your support and collaboration.

Best regards,
The MRTK3 team

@AMollis AMollis added Priority: Very Low The priority of the issue is very low. and removed Priority: Low The priority of the issue is low. labels Jan 2, 2024
@anonymous2585
Copy link
Contributor Author

In our project, we have our own implementation of a Virtual Scrolling View, that recycles gameobjects instead of destroy and re-instantiate. Right now, the SeeItSayItLabelEnabler is not updated when the button's text is updated with the new speed keyword.

With this changes, we should be able to also support automatic speech keyword update depending on the user language, just by adding the build-in Localized String Event component from the Unity Localization package on all our pressable buttons:
image

I hope to have the time to implement this, because right now, we are showing wrong label to our users (It's better to disable the See It Say It Label). If so, I will do a PR so everyone can benefit of this 😀

anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jan 10, 2024
@AMollis AMollis added Priority: Medium The priority of the issue is medium. and removed Priority: Very Low The priority of the issue is very low. labels Jan 17, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 24, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 24, 2024
@anonymous2585 anonymous2585 linked a pull request Jun 24, 2024 that will close this issue
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 24, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 25, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 26, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jun 26, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 1, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 11, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 11, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 11, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 11, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 16, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 16, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 16, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 16, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 19, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 19, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 19, 2024
anonymous2585 pushed a commit to anonymous2585/MixedRealityToolkit-Unity that referenced this issue Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium The priority of the issue is medium. Type: Feature Request A request for a new feature that can be included with the next minor version release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants