Skip to content

Commit

Permalink
Merge pull request #42 from Kshatrix/reconcile-templates
Browse files Browse the repository at this point in the history
Don't skip chart validation if template is valid
  • Loading branch information
Kshatrix authored Jun 20, 2024
2 parents 19ccd58 + f16418d commit 34b81fd
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions internal/controller/template_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ func (r *TemplateReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
l.Error(err, "Failed to get Template")
return ctrl.Result{}, err
}
if template.Status.Valid {
// We consider Template objects immutable, so we validate only once.
// The chart will be validated later, when reconciling Deployment objects.
l.Info("Template has already been validated, skipping validation")
return ctrl.Result{}, nil
}
l.Info("Reconciling helm-controller objects ")
err := r.reconcileHelmRepo(ctx, template)
if err != nil {
Expand Down

0 comments on commit 34b81fd

Please sign in to comment.