Add handling of Personal Access Token in Confluence data connector #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are PAT's only for self-hosted versions? Like they dont exist in the cloud version of Confluence? |
|
I don't know. Only have this self hosted version I can test with. I tried with basic auth, which did not work, but auth with bearer works fine, then I saw in the code, that for this the PersonalAccessToken is used, so i added it in the interface, so I can use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Relevant Issues
resolves #2704
What is in this change?
Additional Information
I basically just hacked it together, to see if I can make use of the connector and was lacking the PAT functionality. And only used docker-compose up --build to test it.
Tested with a Personal Access Token on a self hosted instance.
Not tested with Username/Password, as the instance does not allow this.
Developer Validations
yarn lintfrom the root of the repo & committed changes