Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagoda to RPC options #552

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Add Pagoda to RPC options #552

merged 1 commit into from
Nov 8, 2024

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Nov 8, 2024

PR Type

enhancement


Description

  • Added 'pagoda' as a new option to the RPC_OPTIONS type in the TypeScript SDK.

Changes walkthrough 📝

Relevant files
Enhancement
types.ts
Add 'pagoda' option to RPC_OPTIONS type                                   

packages/sdk/src/types.ts

  • Added 'pagoda' to the RPC_OPTIONS type.
+1/-1     

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

@mintbase-codium-pr-agent
Copy link

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No key issues to review

@mintbase-codium-pr-agent
Copy link

PR Code Suggestions ✨

CategorySuggestion                                                                                                                                    Score
Maintainability
Add a semicolon to ensure consistency and adherence to TypeScript syntax

Add a semicolon at the end of the type declaration for RPC_OPTIONS to maintain
consistency and adhere to TypeScript best practices.

packages/sdk/src/types.ts [121]

-export type RPC_OPTIONS  = 'lava' | 'near' | 'pagoda' | 'fastnear'
+export type RPC_OPTIONS  = 'lava' | 'near' | 'pagoda' | 'fastnear';
 
Suggestion importance[1-10]: 8

Why: Adding a semicolon at the end of the type declaration is a good practice in TypeScript for consistency and readability, even though it's not strictly necessary.

8

@tifrel tifrel merged commit 678576c into beta Nov 8, 2024
2 checks passed
@tifrel tifrel deleted the pagoda-rpc-option branch November 8, 2024 07:51
Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iz good. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants