Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query account by public key #408

Merged
merged 5 commits into from
Oct 16, 2023
Merged

Query account by public key #408

merged 5 commits into from
Oct 16, 2023

Conversation

tifrel
Copy link
Member

@tifrel tifrel commented Oct 12, 2023

No description provided.

Copy link
Contributor

@bh2smith bh2smith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!


{% code title="accountsByPublicKey.ts" overflow="wrap" lineNumbers="true" %}

```typescript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: I believe you can also go with just ts here:

Suggested change
```typescript
```ts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, but this is consistent with the rest of documentation (I just copied the template from another README)


const { data, error } = await accountsByPublicKey('ed25519:12345...');

if (error) {console.log('error', error)}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ubernit:

Suggested change
if (error) {console.log('error', error)}
if (error) {console.error(error)}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above, we'll keep it consistent with other docs

@github-actions github-actions bot temporarily deployed to production October 16, 2023 10:51 Inactive
@github-actions github-actions bot temporarily deployed to production October 16, 2023 11:59 Inactive
@tifrel tifrel merged commit 0af5363 into beta Oct 16, 2023
7 checks passed
@tifrel tifrel deleted the data-account-by-pubkey branch February 5, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants