Ore replacements - Ore dict based?

[ghost]

It would be nice if the ore replacement that happens during generation could also occur for all other modded ores that Minestrapp includes by default, such as copper. Using the ore dictionary to determine if an ore is the same type as a Minestrapp ore might be a good way to determine which blocks should be replaced.

A config option to disable this would also be useful for pack makers where ores of the same metal don't necessarily behave the same, I assume.

[Delocuro]

Hmm... not a bad idea, except I'd need to rework how worldgen works a little bit. In M4, ore gen worked exactly like you were saying - Minestrapp generated all of its ores as their normal Stone variants and then replaced them with the proper biome versions while generating the custom stone types and replacing Vanilla ores.

However, Minestrapp 5's way of doing it is a bit more efficient - it instead checks the biome while generating each ore vein, and then generates them in the right stone type to begin with, thus eliminating the need to effectively generate each ore block twice. This has some unintended consequences - ie, the minor bug where Minestrapp ores sometimes generate with the wrong stone type near biome borders - but overall it saves a good bit of extra processing during worldgen, which is one of the several reasons M5 generates so much faster than M4.

I could revert to the old system, but that'd potentially cause increased worldgen lag, so I'd have to do some tests and see if it's noticable at all. Plus we don't have a config yet, so that'll still be at least a version or two. I'll put this one on the backburner for now, but I'll leave it open to remember to come back to it at some point in the future.

[ghost]

If it's less efficient, no worries, I and other pack devs can just disable the other mod ore gen and use an ore gen mod to place in minestrapp versions ourselves. A little more work for us, but if it's more efficient than the old generation system then the player is better off for the effort of the pack dev.