Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New article "Minimize an extension's impact on page load time" #3272

Merged
merged 8 commits into from
Sep 19, 2024
Merged

New article "Minimize an extension's impact on page load time" #3272

merged 8 commits into from
Sep 19, 2024

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Sep 18, 2024 •
edited by mikehoffms
Loading

Rendered article for review:

New article for extension developers to learn how to make their content scripts less impactful for webpage load times.

AB#53989844

@captainbrosset captainbrosset added cat: extensions Extensions-related content. labels Sep 18, 2024
@mikehoffms mikehoffms changed the title New best practices article for extension content scripts New article "Minimize an extension's impact on page load time" Sep 18, 2024
mikehoffms
mikehoffms approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; Approved PR per Writer/Editor pass, after pushing commits

andrejo-msft
andrejo-msft approved these changes Sep 19, 2024
View reviewed changes
Copy link

@andrejo-msft andrejo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit: - Approved by PdM

@learn-build-service-prod Learn Build Service (PROD)
Copy link

Learn Build status updates of commit 121c682:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/evaluate-script-event.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/more-tools-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/performance-tool-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/profile.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/record-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/stop-icon.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact-images/tracing-event-selected.png ✅Succeeded View
microsoft-edge/extensions-chromium/developer-guide/minimize-page-load-time-impact.md ✅Succeeded View
microsoft-edge/extensions-chromium/landing/index.yml ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit e8f07f2 into main Sep 19, 2024
2 checks passed
@captainbrosset captainbrosset deleted the user/pabrosse/ext-best-practices branch September 19, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikehoffms mikehoffms mikehoffms approved these changes

@andrejo-msft andrejo-msft andrejo-msft approved these changes

Assignees
No one assigned
Labels
cat: extensions Extensions-related content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@captainbrosset @andrejo-msft @mikehoffms