Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Notes for July/August 2024 Prerelease SDK #3244

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Aug 7, 2024

Rendered article section for review:

This PR does the following:

  • Adds Release section boundary hidden comments, as sequence hints for git merging.
  • Adds Prerelease section, moved from PR 3218.
  • Below that:
    • Removes trailing whitespace.
    • Moves GetDeferral to be last, like Ref docs.
      • get_ items then put_ items, like Ref docs.
      • Separates types, left-justified / promoted left.
    • Removes ICoreWebView2ExperimentalScreenCaptureStartingEventArgs::Invoke 3x.
    • Moves Remove below Insert per Ref docs.
    • Adds comment to keep ICoreWebView2ExperimentalShowSaveAsUICompletedHandler::Invoke per Ref docs.

AB#53080701

Copy link
Contributor

@victorhuangwq victorhuangwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Learn Build status updates of commit f54dcac:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/release-notes/index.md 💡Suggestion View Details

microsoft-edge/webview2/release-notes/index.md

  • Line 107, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2frame.useoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 110, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredbackgroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 111, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredforegroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 112, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredintensivetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 113, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 128, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 129, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#get_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 130, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#put_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 132, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 133, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 134, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 135, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 136, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 137, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 138, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 139, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 140, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 212, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 213, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#add_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 214, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#remove_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 215, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#showsaveasui' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 217, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 218, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_allowreplace' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 219, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_cancel' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 220, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_contentmimetype' points to a learn site page that doesn't exist. Check the path or URL and update the link.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

Copy link

Learn Build status updates of commit 9ee5b3a:

💡 Validation status: suggestions

File Status Preview URL Details
microsoft-edge/webview2/release-notes/index.md 💡Suggestion View Details

microsoft-edge/webview2/release-notes/index.md

  • Line 107, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2frame.useoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 110, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredbackgroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 111, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredforegroundtimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 112, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredintensivetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 113, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/dotnet/api/microsoft.web.webview2.core.corewebview2settings.preferredoverridetimerwakeinterval?view=webview2-dotnet-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 128, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 129, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#get_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 130, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalframe7?view=webview2-1.0.2730-prerelease&preserve-view=true#put_useoverridetimerwakeinterval' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 132, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 133, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 134, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 135, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 136, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#get_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 137, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredbackgroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 138, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredforegroundtimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 139, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredintensivetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 140, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2experimentalsettings9?view=webview2-1.0.2730-prerelease&preserve-view=true#put_preferredoverridetimerwakeintervalinmilliseconds' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 212, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 213, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#add_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 214, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#remove_saveasuishowing' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 215, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2_25?view=webview2-1.0.2730-prerelease&preserve-view=true#showsaveasui' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 217, Column 3: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 218, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_allowreplace' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 219, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_cancel' points to a learn site page that doesn't exist. Check the path or URL and update the link.
  • Line 220, Column 6: [Suggestion: learn-site-link-broken - See documentation] Link '/microsoft-edge/webview2/reference/win32/icorewebview2saveasuishowingeventargs?view=webview2-1.0.2730-prerelease&preserve-view=true#get_contentmimetype' points to a learn site page that doesn't exist. Check the path or URL and update the link.

This comment lists only the first 25 errors (including error/warning/suggestion) in the pull request.
For more details, please refer to the build report.

Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@mikehoffms mikehoffms added the cat: webview2 WebView-related content. label Aug 7, 2024
@Reezaali Reezaali merged commit 580f638 into main Aug 7, 2024
2 checks passed
@Reezaali Reezaali deleted the user/mikehoffms/relnotes-julaug2024-prerelease branch August 7, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: webview2 WebView-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants