-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update docs for getting token for origin trial #2885
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left two suggestions, and shared my point of view on the 3 outdated origin trials.
I could leave with both options for What's New (either always correct, or snapshot in time), but I tend to lean towards the snapshot in time side. I like the fact that these pages can serve as historical proofs that some things happened. It's also less work for us.
microsoft-edge/progressive-web-apps-chromium/how-to/handle-urls.md
Outdated
Show resolved
Hide resolved
Just to close the loop on this, I think the accepted solution is:
cc @mikehoffms |
done: 1, 2, and most of 3. so far, I haven't added quite so specific as: eg added to DevTools What's New nav page:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I made three suggestions in the what's new PWA article to clarify whether the features that once were in OT are now available or not. Feel free to consider these suggestions and rephrase them if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Learn Build status updates of commit 53552ce: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Rendered article sections for review (ordered per Files Changed page & doc build report):
This PR fixes Issue MicrosoftEdge/MSEdgeExplainers#702 -
[Origin Trial] How to sign in to developer console to enroll for origin trial?
AB#47170262