Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for getting token for origin trial #2885

Merged
merged 23 commits into from
Oct 26, 2023

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Oct 20, 2023

Rendered article sections for review (ordered per Files Changed page & doc build report):

  1. What's New in Microsoft Edge DevTools
  2. Test and automation > Use Origin Trials in Microsoft Edge
  3. Handle links to your Progressive Web Apps
  4. PWA > Experimental features and origin trials
  5. What's New in Progressive Web Apps
  6. Test and automation in Microsoft Edge
  7. toc.yml table of contents file

This PR fixes Issue MicrosoftEdge/MSEdgeExplainers#702 -
[Origin Trial] How to sign in to developer console to enroll for origin trial?

AB#47170262

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms marked this pull request as ready for review October 20, 2023 20:59
@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two suggestions, and shared my point of view on the 3 outdated origin trials.

I could leave with both options for What's New (either always correct, or snapshot in time), but I tend to lean towards the snapshot in time side. I like the fact that these pages can serve as historical proofs that some things happened. It's also less work for us.

microsoft-edge/origin-trials/index.md Outdated Show resolved Hide resolved
@captainbrosset
Copy link
Contributor

Just to close the loop on this, I think the accepted solution is:

  1. Add a note at the top of our various What's New pages that say something like: "Sections of this document correspond to historical releases of Microsoft Edge and are not updated over time. References to new features and experiments might become outdated as new versions of Microsoft Edge get released.".
  2. For PWA specifically, maybe change it to: "...References to new features and origin trials might become outdated..."
  3. As a best effort, add notes next to individual PWA what's new entries that mention the state of the origin trials. Something like: "This origin trial has ended and the feature is now available". Or "This origin trial has ended and experimental support for this feature was removed".

cc @mikehoffms

@mikehoffms
Copy link
Contributor Author

mikehoffms commented Oct 24, 2023

Just to close the loop on this, I think the accepted solution is:

  1. Add a note at the top of our various What's New pages that say something like: "Sections of this document correspond to historical releases of Microsoft Edge and are not updated over time. References to new features and experiments might become outdated as new versions of Microsoft Edge get released.".
  2. For PWA specifically, maybe change it to: "...References to new features and origin trials might become outdated..."
  3. As a best effort, add notes next to individual PWA what's new entries that mention the state of the origin trials. Something like: "This origin trial has ended and the feature is now available". Or "This origin trial has ended and experimental support for this feature was removed".

cc @mikehoffms

done: 1, 2, and most of 3. so far, I haven't added quite so specific as:
"This origin trial has ended and experimental support for this feature was removed."
ready for your review @captainbrosset

eg added to DevTools What's New nav page:

What's New articles correspond to historical releases of Microsoft Edge, and are not updated over time.
References to "new features" and "experiments" might become outdated as new versions of Microsoft Edge are released.

@mikehoffms mikehoffms added cat: pwas Progressive Web Apps-related content cat: devtools DevTools-related content. labels Oct 24, 2023
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I made three suggestions in the what's new PWA article to clarify whether the features that once were in OT are now available or not. Feel free to consider these suggestions and rephrase them if needed.

Copy link
Contributor

@amandabaker amandabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@learn-build-service-prod
Copy link

Learn Build status updates of commit 53552ce:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/whats-new/whats-new.md ✅Succeeded View
microsoft-edge/origin-trials/index.md ✅Succeeded View
microsoft-edge/progressive-web-apps-chromium/how-to/handle-urls.md ✅Succeeded View
microsoft-edge/progressive-web-apps-chromium/how-to/origin-trials.md ✅Succeeded View
microsoft-edge/progressive-web-apps-chromium/whats-new/pwa.md ✅Succeeded View
microsoft-edge/test-and-automation/test-and-automation.md ✅Succeeded View
microsoft-edge/toc.yml ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit a36e890 into main Oct 26, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/mikehoffms/ot-link branch October 26, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content. cat: pwas Progressive Web Apps-related content cat: test-automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants