-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add widget screenshot requirements and update some out of date fields #2858
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
@captainbrosset Would you PTAL? I'm not sure about the wording of the WidgetClick event bit at the end, so lmk if you have suggestions on how to better word that. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Michael Hoffman <[email protected]>
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Michael Hoffman <[email protected]>
Learn Build status updates of commit 9f55a54: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Writer/Editor pass, from the Files Changed POV.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestion for the widgetclick event. PR looks great otherwise. Thank you Amanda.
Co-authored-by: Patrick Brosset <[email protected]>
Learn Build status updates of commit bde980b: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
Rendered article for review:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/how-to/widgets?branch=pr-en-us-2858
[Before]
Changes made by this PR:
matchAll
options frominstance
andhost
toinstanceId
andhostId
.multiple
to the widget definition.widget
on theWidgetEvent
fromWidgetInstance
toWidget
.WidgetClickEvent
allows the SW to open a window in response to the event.AB#46944432