Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add widget screenshot requirements and update some out of date fields #2858

Merged
merged 7 commits into from
Oct 11, 2023

Conversation

amandabaker
Copy link
Contributor

@amandabaker amandabaker commented Oct 9, 2023

Rendered article for review:
https://review.learn.microsoft.com/microsoft-edge/progressive-web-apps-chromium/how-to/widgets?branch=pr-en-us-2858
[Before]

Changes made by this PR:

  • Noted the limitation of both widget screenshots and icons to a max of 1024x1024 pixels.
  • Updated the matchAll options from instance and host to instanceId and hostId.
  • Added multiple to the widget definition.
  • Updated the type of widget on the WidgetEvent from WidgetInstance to Widget.
  • Added a note that a WidgetClickEvent allows the SW to open a window in response to the event.

AB#46944432

@learn-build-service-prod

This comment was marked as outdated.

@amandabaker
Copy link
Contributor Author

@captainbrosset Would you PTAL? I'm not sure about the wording of the WidgetClick event bit at the end, so lmk if you have suggestions on how to better word that.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms self-requested a review October 10, 2023 01:19
@mikehoffms mikehoffms added the cat: pwas Progressive Web Apps-related content label Oct 10, 2023
@learn-build-service-prod

This comment was marked as outdated.

@mikehoffms mikehoffms self-requested a review October 10, 2023 04:23
@learn-build-service-prod
Copy link

Learn Build status updates of commit 9f55a54:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/progressive-web-apps-chromium/how-to/widgets.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Writer/Editor pass, from the Files Changed POV.

Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion for the widgetclick event. PR looks great otherwise. Thank you Amanda.

@learn-build-service-prod
Copy link

Learn Build status updates of commit bde980b:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/progressive-web-apps-chromium/how-to/widgets.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 3d59722 into MicrosoftDocs:main Oct 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: pwas Progressive Web Apps-related content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants