Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus Mode pngs batch 5 (Issues tool) #2844

Merged
merged 8 commits into from
Oct 3, 2023
Merged

Focus Mode pngs batch 5 (Issues tool) #2844

merged 8 commits into from
Oct 3, 2023

Conversation

mikehoffms
Copy link
Contributor

@mikehoffms mikehoffms commented Sep 25, 2023 •
edited
Loading

@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@mikehoffms mikehoffms added on-hold The changes are currently on-hold and awaiting further evaluation. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode cat: devtools DevTools-related content. labels Sep 26, 2023
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
captainbrosset
captainbrosset reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commenting, I know you're not done with this PR yet.

microsoft-edge/devtools-guide-chromium/issues/index.md Outdated Show resolved Hide resolved
microsoft-edge/devtools-guide-chromium/issues/index.md Outdated Show resolved Hide resolved
microsoft-edge/devtools-guide-chromium/issues/index.md Outdated Show resolved Hide resolved
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@mikehoffms mikehoffms marked this pull request as ready for review September 27, 2023 17:47
@learn-build-service-prod

This comment was marked as outdated.

Sign in to view
@captainbrosset captainbrosset changed the base branch from main to user/pabrosse/focus-mode-july-2023 October 3, 2023 07:42
@learn-build-service-prod
Copy link

Learn Build status updates of commit eb26c4f:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/issues/index.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/browser-filter.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/categories.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/elements-tool-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/initial-view-accessibility-page.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/opened-from-dom-tree-wavy-underline.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/ordered-by-severity.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/severity-filter.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/third-party-checkbox.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/view-issue-in-network.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/issues/index-images/wavy-underlines-dom-tree.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/whats-new/2020/08/devtools.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset mentioned this pull request Oct 3, 2023
Merged
@captainbrosset captainbrosset merged commit 5e101f7 into user/pabrosse/focus-mode-july-2023 Oct 3, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/mikehoffms/focus-mode-issues-tool branch October 3, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset approved these changes

Assignees
No one assigned
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode on-hold The changes are currently on-hold and awaiting further evaluation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikehoffms @captainbrosset