Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the new AAD connection type and filtering feature to the symbol server docs #2840

Merged
merged 6 commits into from
Sep 22, 2023

Conversation

captainbrosset
Copy link
Contributor

@captainbrosset captainbrosset commented Sep 19, 2023

It's now possible to add multiple connections, to choose between PAT and AAD authorization, and to filter in/out source maps in the Symbol Server setting screen of DevTools. This PR adds the missing docs for this feature.

Before: https://learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure
After: https://review.learn.microsoft.com/en-us/microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure?branch=pr-en-us-2840 (github preview).

AB#46432272

@captainbrosset captainbrosset added the cat: devtools DevTools-related content. label Sep 19, 2023
Copy link
Contributor

@mikehoffms mikehoffms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial Writer/Editor review pass

@learn-build-service-prod
Copy link

Learn Build status updates of commit c433704:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/ado-pat-devtools.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/ado-preferences-source-maps-devtools.png ✅Succeeded n/a (file deleted or renamed)
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/close-settings-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/create-new-add-connection.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/create-new-pat-connection.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/edit-connection-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/edit-remove-connection.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/filter-inclusion-list.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/preferences-source-maps-devtools.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/remove-connection-icon.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/javascript/consume-source-maps-from-azure-images/select-aad-org.png ✅Succeeded View
microsoft-edge/web-platform/os-regional-settings.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit 22006ed into main Sep 22, 2023
1 check passed
@captainbrosset captainbrosset deleted the user/pabrosse/symbol-server-aad branch September 22, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants