Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Focus Mode] Update doc and screenshots in Storage #2699

Conversation

yanlingwang23
Copy link
Contributor

Update the screenshots in the following articles:

  • cookies
  • cache

@captainbrosset captainbrosset added cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode labels Jul 13, 2023
Copy link
Contributor

@captainbrosset captainbrosset left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we'd draw red boxes on pretty much all of these screenshots, to attract the reader's attention to the right places. But seeing how none of the old screenshots had these boxes either, I'm approving this PR. It's a good first step, and we can improve the images in a follow-up PR.
Thanks!

@captainbrosset captainbrosset changed the base branch from main to user/pabrosse/focus-mode-july-2023 July 21, 2023 09:35
@learn-build-service-prod
Copy link

Learn Build status updates of commit 17481f0:

✅ Validation status: passed

File Status Preview URL Details
microsoft-edge/devtools-guide-chromium/storage/cache.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-delete-selected.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-domain-js-preview.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-domain-refresh.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-domain-root-headers.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-filter.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-cache-storage-index-headers.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-clear-storage-cache-storage-checkbox.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-clear-storage-cache-storage-checkbox-clear-site-data-button.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cache-images/storage-application-manifest.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies.md ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/clear-all-cookies.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/delete-selected-cookie.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/filter-cookies-name.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/open-cookies-select-source.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/pick-application-no-manifest.png ✅Succeeded View
microsoft-edge/devtools-guide-chromium/storage/cookies-images/rename-cookie.png ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@captainbrosset captainbrosset merged commit f79d2fe into MicrosoftDocs:user/pabrosse/focus-mode-july-2023 Jul 21, 2023
@captainbrosset
Copy link
Contributor

Ideally we'd draw red boxes on pretty much all of these screenshots, to attract the reader's attention to the right places. But seeing how none of the old screenshots had these boxes either, I'm approving this PR. It's a good first step, and we can improve the images in a follow-up PR.

Now addressed in PR #2724.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: devtools DevTools-related content. focus-mode-screenshots These PRs are about renewing screenshots in the DevTools docs for Focus Mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants