Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite about_modules #10720

Merged
merged 4 commits into from
Dec 7, 2023
Merged

Rewrite about_modules #10720

merged 4 commits into from
Dec 7, 2023

Conversation

sdwheeler
Copy link
Contributor

@sdwheeler sdwheeler commented Dec 7, 2023 •
edited by azure-boards bot
Loading

PR Summary

Rewrite about_modules

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

@learn-build-service-prod Learn Build Service (PROD)

This comment was marked as outdated.

Sign in to view
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit 34599d7:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

michaeltlombardi
michaeltlombardi requested changes Dec 7, 2023
View reviewed changes
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md Outdated Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md Outdated Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md Outdated
Comment on lines 85 to 86
Copy-Item -Path C:\ps-test\MyModule -Destination `
$HOME\Documents\WindowsPowerShell\Modules
$HOME\Documents\PowerShell\Modules
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copy-Item -Path C:\ps-test\MyModule -Destination `
$HOME\Documents\WindowsPowerShell\Modules
$HOME\Documents\PowerShell\Modules
Copy-Item -Path C:\ps-test\MyModule -Destination $folder

reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md Outdated Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md Outdated Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md Show resolved Hide resolved
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md Outdated Show resolved Hide resolved
reference/7.2/Microsoft.PowerShell.Core/About/about_Modules.md Outdated Show resolved Hide resolved
@sdwheeler @michaeltlombardi
Apply suggestions from code review
d061eb0 
Co-authored-by: Mikey Lombardi (He/Him) <[email protected]>
@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit d061eb0:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

@learn-build-service-prod Learn Build Service (PROD)
Copy link
Contributor

Learn Build status updates of commit d0ea992:

✅ Validation status: passed

File Status Preview URL Details
reference/5.1/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-5.1)
reference/5.1/Microsoft.PowerShell.Core/About/about_PSSnapins.md ✅Succeeded View (powershell-5.1)
reference/7.2/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.2)
reference/7.2/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.2)
reference/7.3/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.3)
reference/7.3/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.3)
reference/7.4/Microsoft.PowerShell.Core/About/about_Modules.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_PowerShell_Config.md ✅Succeeded View (powershell-7.4)
reference/7.4/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.4)

For more details, please refer to the build report.

For any questions, please:

@michaeltlombardi michaeltlombardi merged commit 02cba40 into MicrosoftDocs:main Dec 7, 2023
4 checks passed
@sdwheeler sdwheeler deleted the sdw-w190105-module branch December 11, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeltlombardi michaeltlombardi michaeltlombardi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdwheeler @michaeltlombardi