Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Words that have numbers on the end fail. #63

Open
shaleh opened this issue Mar 17, 2022 · 2 comments
Open

Words that have numbers on the end fail. #63

shaleh opened this issue Mar 17, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@shaleh
Copy link
Contributor

shaleh commented Mar 17, 2022

I have a similar issue to #61 which currently makes the plugin unusable. The below happens despite using all of the dictionaries.

data.py:28:41: SC200 Possibly misspelt word: 'dict1'
data.py:58:36: SC200 Possibly misspelt word: 'file1'

An approach that notices the trailing numbers, checks if the word is valid and then allows the whole word to pass seems straight forward and unlikely to introduce failures. xyz1 is not a valid word. file1 clear is "file one".

I am happy to post a PR if that approach is acceptable.

I am using 0.25.0 installed from pypi.

@MichaelAquilina
Copy link
Owner

@shaleh seems like a reasonable idea! We can make also make it an option in case people want to disable it too.

Feel free to open a PR with your suggestion :)

@MichaelAquilina MichaelAquilina added enhancement New feature or request help wanted Extra attention is needed labels Mar 18, 2022
@shaleh
Copy link
Contributor Author

shaleh commented Mar 19, 2022

Excellent. Let me see if I can get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants