Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Home: Character limit, formatting and editing alerts #1076

Open
shrayshray opened this issue Feb 12, 2024 · 4 comments
Open

Home: Character limit, formatting and editing alerts #1076

shrayshray opened this issue Feb 12, 2024 · 4 comments
Assignees

Comments

@shrayshray
Copy link
Collaborator

A couple questions about the alerts (#1010) banner functionality:

  1. Is there a character limit on alerts?
  2. Can we add line breaks in alerts?
  3. Can existing alerts be edited? Currently, any changes to an existing alert can only be made by creating a new alert and deleting the existing alert.
@xmedr
Copy link
Collaborator

xmedr commented Feb 28, 2024

@shrayshray great questions!

  1. The practical answer is no, there is no character limit for alerts. In reality there is a limit but it's super high, 1GB of text in total which translates to books worth of pages/words. Is a smaller character limit something you folks wanted in place?
  2. We can absolutely add the ability for line breaks! I'll add a new button as well to make inserting those a bit easier.
  3. You're right, as of now that's the only way to edit alerts. We'll work on adding an edit button to help with that!

@xmedr
Copy link
Collaborator

xmedr commented Mar 15, 2024

@shrayshray update: we've got the functionality working for line breaks and editing (see gif below). we'll just be moving the alert manager to a dedicated page and it'll be good to go! with the addition of the edit form, we're hoping giving the manager its own page will help to clarify and declutter things.

edit-alerts

@shrayshray
Copy link
Collaborator Author

@xmedr looks great!

@antidipyramid antidipyramid moved this from 📤 Review/QA to 📝 In Progress in boardagendas.metro.net - Monthly priorities Mar 19, 2024
@xmedr
Copy link
Collaborator

xmedr commented Mar 19, 2024

@shrayshray great! this has been added into the live site. we've added a new Admin dropdown to the navbar when logged in, in case we add more of these kinds of features. and the alerts have been moved into a link there. here's an updated preview of what that looks like

Screen.Recording.2024-03-19.at.4.28.58.PM.mov

@xmedr xmedr moved this from 📝 In Progress to ✅ Done in boardagendas.metro.net - Monthly priorities Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants