feat: Add seed liquidity single bin #122
Conversation
quangkeu95
requested review from
andrewsource147 and
codewithgun
and removed request for
andrewsource147
quangkeu95
force-pushed
the
feat/seed-liquidity-single-bin
branch
from
762588e to
7f11467
Compare
ts-client/src/dlmm/index.ts
Outdated
| const pricePerLamport = DLMM.getPricePerLamport(this.tokenX.decimal, this.tokenY.decimal, price); | ||
| const binIdNumber = DLMM.getBinIdFromPrice(pricePerLamport, this.lbPair.binStep, !roundingUp); | ||
|
|
||
| if (tokenXBpsDistribution + tokenYBpsDistribution != 10000) { |
There was a problem hiding this comment.
Each tokenXBpsDistribution and tokenYBpsDistribution need to be <= 10_000, not combined.
ts-client/src/dlmm/index.ts
Outdated
| tokenXSeedAmount: BN, | ||
| tokenYSeedAmount: BN, | ||
| tokenXBpsDistribution: number, | ||
| tokenYBpsDistribution: number, |
There was a problem hiding this comment.
Since it's single bin, I don't think we need this parameter because it will be 100% of tokenXSeedAmount and tokenYSeedAmount
ts-client/src/dlmm/index.ts
Outdated
| if (!positionAccount) { | ||
| preInstructions.push( | ||
| await this.program.methods | ||
| .initializePositionPda(binId.toNumber(), 1) |
There was a problem hiding this comment.
I think we need to support custom fee owner by using initializePositionByOperator endpoint
ts-client/src/dlmm/index.ts
Outdated
| * @param {PublicKey} funder - The public key of the funder. | ||
| * @return {Promise<TransactionInstruction[]>} An array of transaction instructions to initialize the bin arrays. | ||
| */ | ||
| public async initializeBinArrayBitMapExtension(binArrayBitmapExtension: PublicKey, funder: PublicKey): Promise<TransactionInstruction[]> { |
There was a problem hiding this comment.
I don't see this function used anywhere. If we want to remain this, I think we should
- No need to pass
binArrayBitmapExtensionas parameter, it can be derived internally. - Return type
Promise<TransactionInstruction[]>should beTransactionInstructiononly
There was a problem hiding this comment.
sorry this function is not needed anymore, i will remove it
| * - `price`: Price in UI format | ||
| * - `base`: Base key | ||
| * - `roundingUp`: | ||
| * @returns {Promise<TransactionInstruction[]>} |
There was a problem hiding this comment.
Can you add comment to indicate that the returned instructions need to be executed sequentially if it was separated into multiple transaction?
| owner: PublicKey, | ||
| base: PublicKey, | ||
| seedAmount: BN, | ||
| isTokenX: boolean, |
There was a problem hiding this comment.
because the purpose of endpoint is to seed liquidity for launchpool, so I think you can remove that flag
(I thought that is created for general purpose)
No description provided.