Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/getBins doesnt work correctly if more than 2 bin arrays #116

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix/getBins doesnt work correctly if more than 2 bin arrays #116

wants to merge 2 commits into from

Conversation

00xSam
Copy link
Contributor

@00xSam 00xSam commented Nov 3, 2024

No description provided.

@00xSam 00xSam changed the title Fix/getBins doesnt work if more than 2 bin arrays Fix/getBins doesnt work correctly if more than 2 bin arrays Nov 3, 2024
@shadeglare
Copy link
Contributor

I found possible erroneous behaviour the getBins method can produce. if lowerBinId and upperBinId are equal and there's no bin array for it the method returns empty bins array but when lowerBinId and upperBinId aren't equal it can skip bins completely.

@shadeglare
Copy link
Contributor

Refactored the getBins method in a more concise manner: #119
Already tested in production on https//udlmm.xyz
cc: @00xSam, @codewithgun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codewithgun codewithgun codewithgun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@00xSam @shadeglare @codewithgun