Add backgroundColor property to Container component #2950
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
backgroundColor
property toContainer
component.Related task: #2906
Related extension PR: MetaMask/metamask-extension#29095
Notes
default
andalternative
.backgroundDefault
andbackgroundAlternative
colors from MetaMask extension design system (https://github.com/MetaMask/metamask-extension/blob/main/ui/helpers/constants/design-system.ts#L54).Box
element made in form of addingbackgroundColor?: string | undefined;
are made in order to avoid errors on extension side, because container is reusingBoxElement
type instead of having its own: https://github.com/MetaMask/metamask-extension/blob/main/ui/components/app/snaps/snap-ui-renderer/components/container.ts#L13Examples (experiments with extension integration)
Confirmation example:
Source code used for content:
Transaction insight example where background color is deliberately ignored:
Source code used for content: