Add basic support for account RPC methods in snaps simulator #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mrtenz
requested changes
Aug 30, 2023
Co-authored-by: Maarten Zuidhoorn <[email protected]>
Mrtenz
previously approved these changes
Aug 30, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
=======================================
Coverage 95.87% 95.87%
=======================================
Files 239 239
Lines 5401 5409 +8
Branches 836 836
=======================================
+ Hits 5178 5186 +8
Misses 223 223
☔ View full report in Codecov by Sentry. |
Mrtenz
reviewed
Aug 30, 2023
| @@ -80,16 +80,20 @@ export function* initSaga({ payload }: PayloadAction<string>) { | |||
|
|
|||
| const srp: string = yield select(getSrp); | |||
|
|
|||
| const sharedHooks = { | |||
| getMnemonic: async () => mnemonicPhraseToBytes(srp), | |||
There was a problem hiding this comment.
None of the hooks are currently covered because we don't have tests that run them directly. IMO out of scope for this PR and not exactly sure how we test to cover them
Mrtenz
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for account RPC methods in the simulator by deriving the first address of the SRP and returning that when
eth_requestAccountsoreth_accountsis requested. In the future, we should provide a permission flow that mirrors MetaMask clients, but for now this is useful.Fixes #1578