Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix development peerDependency warnings #468

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 26, 2024

The @lavamoat/preinstall-always-fail package has been added, and the package eslint-plugin-import package has been downgraded by a minor version, both to meet peerDependency requirements of other development dependencies.

The import plugin downgrade resulted in new lint warnings about import order, which were addressed.

Resolves two warnings, no functional changes.

Copy link

socket-security bot commented Nov 26, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@lavamoat/[email protected] None 0 3.53 kB lmbot
npm/[email protected] None 0 13.5 kB ljharb
npm/[email protected] None 0 26.3 kB ljharb
npm/[email protected] None +2 53.7 kB ljharb
npm/[email protected] None +1 38.9 kB ljharb
npm/[email protected] None 0 12.3 kB ljharb
npm/[email protected] None 0 9.99 kB ljharb
npm/[email protected] None 0 12.2 kB ljharb
npm/[email protected] None +1 2.39 MB ljharb
npm/[email protected] None 0 9.17 kB ljharb
npm/[email protected] None +1 31.5 kB ljharb
npm/[email protected] Transitive: environment +1 58.5 kB ljharb
npm/[email protected] None 0 54.6 kB ljharb
npm/[email protected] filesystem, unsafe Transitive: environment, network +3 1.22 MB ljharb
npm/[email protected] None 0 25.5 kB ljharb
npm/[email protected] None 0 14.3 kB ljharb
npm/[email protected] None 0 23.7 kB ljharb
npm/[email protected] None 0 20.5 kB ljharb
npm/[email protected] None 0 17.6 kB ljharb
npm/[email protected] eval 0 19.5 kB ljharb
npm/[email protected] None 0 15.6 kB ljharb
npm/[email protected] None 0 20.8 kB ljharb
npm/[email protected] None 0 16.2 kB ljharb
npm/[email protected] eval 0 31.9 kB ljharb
npm/[email protected] None 0 20.4 kB ljharb
npm/[email protected] None 0 27.1 kB ljharb
npm/[email protected] None 0 19.7 kB ljharb
npm/[email protected] None 0 20.6 kB ljharb
npm/[email protected] None 0 21.2 kB ljharb
npm/[email protected] None 0 3.43 kB juliangruber
npm/[email protected] None 0 101 kB emilbayes, ljharb
npm/[email protected] None 0 72.7 kB ljharb
npm/[email protected] None 0 31.5 kB ljharb
npm/[email protected] None 0 22.1 kB ljharb
npm/[email protected] None 0 43.7 kB ljharb
npm/[email protected] None 0 16.4 kB ljharb
npm/[email protected] None 0 10.2 kB ljharb
npm/[email protected] None 0 95.8 kB npm-cli-ops
npm/[email protected] None 0 16.7 kB ljharb
npm/[email protected] None 0 33.5 kB ljharb
npm/[email protected] None 0 22.1 kB ljharb
npm/[email protected] None 0 22.9 kB ljharb
npm/[email protected] None 0 13.1 kB ljharb
npm/[email protected] None 0 20 kB ljharb
npm/[email protected] None 0 18.1 kB ljharb
npm/[email protected] None 0 24.2 kB ljharb
npm/[email protected] None 0 29 kB ljharb
npm/[email protected] None 0 20.1 kB ljharb

🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Nov 26, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/[email protected], npm/[email protected], npm/@lavamoat/[email protected]

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 26, 2024

@SocketSecurity ignore npm/[email protected]

Looks like the net package is used for the Socket API, it's not actually making network requests.

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 26, 2024

@SocketSecurity ignore npm/[email protected]

New author is known/trusted

@Gudahtt
Copy link
Member Author

Gudahtt commented Nov 26, 2024

@SocketSecurity ignore npm/@lavamoat/[email protected]

This is our package

The `@lavamoat/preinstall-always-fail` package has been added, and the
package `eslint-plugin-import` package has been downgraded by a minor
version, both to meet `peerDependency` requirements of other
development dependencies.

Resolves two warnings, no functional changes.
@Gudahtt Gudahtt force-pushed the fix-development-peer-dependency-warnings branch from 7a85308 to dee73c7 Compare November 26, 2024 17:52
@Gudahtt Gudahtt marked this pull request as ready for review November 26, 2024 18:00
@Gudahtt Gudahtt requested a review from a team as a code owner November 26, 2024 18:00
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit 5bdc0b3 into main Nov 26, 2024
16 checks passed
@Gudahtt Gudahtt deleted the fix-development-peer-dependency-warnings branch November 26, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants