Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to extract API interactions and reduce complexity #188

Open
mcmire opened this issue Aug 18, 2023 · 0 comments
Open

Refactor to extract API interactions and reduce complexity #188

mcmire opened this issue Aug 18, 2023 · 0 comments

Comments

@mcmire
Copy link
Contributor

mcmire commented Aug 18, 2023

At a glance, the updateSmartTransaction, confirmSmartTransaction, getFees, and submitSignedTransactions methods look fairly complex. We should see if we can extract the logic here to separate files to make this controller easier to understand and test.

We should also see if we can extract API interactions, especially the logic involved to normalize response data, to separate files, for the same reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants