Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix swaps button on asset overview page for multichain feature #12650

Merged
merged 5 commits into from
Dec 12, 2024
Merged

fix: fix swaps button on asset overview page for multichain feature #12650

merged 5 commits into from
Dec 12, 2024
+13 −3

Conversation

sahar-fehri
Copy link
Contributor

@sahar-fehri sahar-fehri commented Dec 11, 2024 •
edited
Loading

Description

When user has "all Networks" selected; and he is on a network that does not support swaps but clicks on a network on a chain that supports swaps. He should be able to see the swaps button

Related issues

Fixes: #12546 (comment)

Manual testing steps

  1. Click on "All Networks"
  2. Switch to a network where swaps is not supported (you can add Scroll or blast from chainlist)
  3. Click on a token from ethereum network
  4. You should be able to see swaps button

Screenshots/Recordings

Before

After

Screen.Recording.2024-12-11.at.22.23.38.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions GitHub Actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sahar-fehri sahar-fehri added the Run Smoke E2E Triggers smoke e2e on Bitrise label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 47a4718
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ee0783af-e5ce-4d00-b865-1e71ef57cdab

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri marked this pull request as ready for review December 11, 2024 21:24
@sahar-fehri sahar-fehri requested review from a team as code owners December 11, 2024 21:24
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ffadc04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/80ae2034-9302-4c1b-a584-599adc3c9d53

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3233475
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c3e22fb1-da58-4ba3-b716-5b00d092920f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

vinnyhoward
vinnyhoward approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@vinnyhoward vinnyhoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 11, 2024
@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 12, 2024 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8543a56
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/69bb9834-94f1-4d8d-9e96-36aa9db7f715

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tommasini
tommasini approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@tommasini tommasini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sahar-fehri sahar-fehri added Run Smoke E2E Triggers smoke e2e on Bitrise and removed Run Smoke E2E Triggers smoke e2e on Bitrise labels Dec 12, 2024
@sahar-fehri sahar-fehri added this pull request to the merge queue Dec 12, 2024
Merged via the queue into main with commit 7e40e3e Dec 12, 2024
48 checks passed
@sahar-fehri sahar-fehri deleted the fix/fix-swaps-button-on-asset-detail-page branch December 12, 2024 13:54
@github-actions github-actions bot locked and limited conversation to collaborators Dec 12, 2024
@metamaskbot metamaskbot added the release-7.38.0 Issue or pull request that will be included in release 7.38.0 label Dec 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@infiniteflower infiniteflower infiniteflower approved these changes

@tommasini tommasini tommasini approved these changes

@gambinish gambinish gambinish approved these changes

@vinnyhoward vinnyhoward vinnyhoward approved these changes

@bergeron bergeron bergeron approved these changes

Assignees
No one assigned
Labels
release-7.38.0 Issue or pull request that will be included in release 7.38.0 Run Smoke E2E Triggers smoke e2e on Bitrise team-assets
Projects
PR review queue
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Portfolio view: Swap button unavailable for non-native tokens in All networks view
7 participants
@sahar-fehri @bergeron @vinnyhoward @gambinish @tommasini @infiniteflower @metamaskbot