Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Permissions functionality exhibits differences between the current main and the PV build #12619

Closed
sleepytanya opened this issue Dec 10, 2024 · 2 comments
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Dec 10, 2024

Describe the bug

Permissions menu in main and in PV (not sure if it's expected)

Image

PancakeSwap

main build

Permissions are accurately updated when a user selects a different network in the wallet, with transactions being correctly created on the chosen network. Wallet and dApp networks icons show the selected network.

pancakeMain.mp4

PV build

Transactions created on an incorrect network because the dApp continues to operate under the assumption that it is connected to the previous network until the user manually switches the network within the dApp. The wallet and dApp icons indicate different chains.

pancakePV.mov

In both builds, SushiSwap and Uniswap exhibit similar behavior in that permissions are not updated until the user manually switches the network within the dApp. Additionally, there is a discrepancy where the wallet and dApp icons indicate different chains.

SushiSwap

sushiMain.mp4
sushiPV.mov

Uniswap

uniswapMain.mov
uniswapMain.mov

Expected behavior

Screenshots/Recordings

No response

Steps to reproduce

  1. Connect to a dApp
  2. Switch networks

Error messages or log output

Detection stage

On the development branch

Version

main and PV builds

Build type

None

Device

Samsung S24+

Operating system

Android

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working labels Dec 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Dec 10, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Dec 10, 2024
@Unik0rnMaggie
Copy link
Contributor

Permissions Main vs Portfolio view:

Image

Image

@sleepytanya
Copy link
Contributor Author

Permissions view fixed in this build: https://app.bitrise.io/app/be69d4368ee7e86d/installable-artifacts/13eeff1e9ecca49d/public-install-page/73ac6667897d6ece66abb7aa43a7a681

Network is correctly updated in the Pancakeswap dapp, txs created on the selected network, correct network icons displayed:

Screen_Recording_20241210_230110_MetaMask.mp4

@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Dec 11, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
portfolio-view Used for PRs and issues related to Q4 2024 portfolio view Sev2-normal An issue that may lead to users misunderstanding some limited risks they are taking team-assets type-bug Something isn't working
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

2 participants