From 0f1a8a0c1bcf7d9434905614b0fc6ec18f7233f9 Mon Sep 17 00:00:00 2001 From: sethkfman <10342624+sethkfman@users.noreply.github.com> Date: Mon, 25 Nov 2024 15:03:15 -0700 Subject: [PATCH] chore: update codeowners (#12238) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Updating codeowners file to remove mobile platform from all files co-owned and removed files from @MetaMask/supply-chain ownership. This was based on data from the most frequently touched files and cross-team impact. [decoupling_report.csv](https://github.com/user-attachments/files/17670808/decoupling_report.csv) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- .github/CODEOWNERS | 59 +++++++++++++++++++++++----------------------- 1 file changed, 29 insertions(+), 30 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 796a961d095..16348bdf720 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -7,6 +7,7 @@ app/component-library/ @MetaMask/design-system-engineers # Platform Team +.github/CODEOWNERS @MetaMask/mobile-platform patches/ @MetaMask/mobile-platform app/core/Engine/Engine.ts @MetaMask/mobile-platform app/core/Engine/Engine.test.ts @MetaMask/mobile-platform @@ -15,49 +16,48 @@ app/core/Engine/types.ts @MetaMask/mobile-platform app/core/Analytics/ @MetaMask/mobile-platform app/util/metrics/ @MetaMask/mobile-platform app/components/hooks/useMetrics/ @MetaMask/mobile-platform - -# Supply Chain Team -bitrise.yml @MetaMask/supply-chain @MetaMask/mobile-platform -yarn.lock @MetaMask/supply-chain @MetaMask/mobile-platform -ios/Podfile.lock @MetaMask/supply-chain @MetaMask/mobile-platform +app/store/migrations/ @MetaMask/mobile-platform +bitrise.yml @MetaMask/mobile-platform +yarn.lock @MetaMask/mobile-platform +ios/Podfile.lock @MetaMask/mobile-platform # Ramps Team -app/components/UI/Ramp/ @MetaMask/ramp @MetaMask/mobile-platform -app/reducers/fiatOrders/ @MetaMask/ramp @MetaMask/mobile-platform +app/components/UI/Ramp/ @MetaMask/ramp +app/reducers/fiatOrders/ @MetaMask/ramp # Confirmation Team -app/components/Views/confirmations @MetaMask/confirmations @MetaMask/mobile-platform -ppom @MetaMask/confirmations @MetaMask/mobile-platform +app/components/Views/confirmations @MetaMask/confirmations +ppom @MetaMask/confirmations # All below files are maintained by the SDK team because they contain SDK related code, WalletConnect integrations, or critical SDK flows. -app/actions/sdk @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Approvals/WalletConnectApproval @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Views/SDK @MetaMask/sdk-devs @MetaMask/mobile-platform -app/components/Views/WalletConnectSessions @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/BackgroundBridge/WalletConnectPort.ts @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/DeeplinkManager @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/RPCMethods/RPCMethodMiddleware.ts @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/SDKConnect @MetaMask/sdk-devs @MetaMask/mobile-platform -app/core/WalletConnect @MetaMask/sdk-devs @MetaMask/mobile-platform -app/reducers/sdk @MetaMask/sdk-devs @MetaMask/mobile-platform -app/util/walletconnect.js @MetaMask/sdk-devs @MetaMask/mobile-platform +app/actions/sdk @MetaMask/sdk-devs +app/components/Approvals/WalletConnectApproval @MetaMask/sdk-devs +app/components/Views/SDK @MetaMask/sdk-devs +app/components/Views/WalletConnectSessions @MetaMask/sdk-devs +app/core/BackgroundBridge/WalletConnectPort.ts @MetaMask/sdk-devs +app/core/DeeplinkManager @MetaMask/sdk-devs +app/core/RPCMethods/RPCMethodMiddleware.ts @MetaMask/sdk-devs +app/core/SDKConnect @MetaMask/sdk-devs +app/core/WalletConnect @MetaMask/sdk-devs +app/reducers/sdk @MetaMask/sdk-devs +app/util/walletconnect.js @MetaMask/sdk-devs # Accounts Team app/core/Encryptor/ @MetaMask/accounts-engineers app/core/Engine/controllers/accounts @MetaMask/accounts-engineers # Swaps Team -app/components/UI/Swaps @MetaMask/swaps-engineers @MetaMask/mobile-platform +app/components/UI/Swaps @MetaMask/swaps-engineers # Notifications Team -app/components/Views/Notifications @MetaMask/notifications @MetaMask/mobile-platform -app/components/Views/Settings/NotificationsSettings @MetaMask/notifications @MetaMask/mobile-platform -app/components/UI/Notifications @MetaMask/notifications @MetaMask/mobile-platform -app/reducers/notification @MetaMask/notifications @MetaMask/mobile-platform -app/actions/notification @MetaMask/notifications @MetaMask/mobile-platform -app/selectors/notification @MetaMask/notifications @MetaMask/mobile-platform -app/util/notifications @MetaMask/notifications @MetaMask/mobile-platform -app/store/util/notifications @MetaMask/notifications @MetaMask/mobile-platform +app/components/Views/Notifications @MetaMask/notifications +app/components/Views/Settings/NotificationsSettings @MetaMask/notifications +app/components/UI/Notifications @MetaMask/notifications +app/reducers/notification @MetaMask/notifications +app/actions/notification @MetaMask/notifications +app/selectors/notification @MetaMask/notifications +app/util/notifications @MetaMask/notifications +app/store/util/notifications @MetaMask/notifications # LavaMoat Team ses.cjs @MetaMask/supply-chain @@ -115,7 +115,6 @@ app/components/Views/QRAccountDisplay @MetaMask/wallet-ux app/components/Views/QRScanner @MetaMask/wallet-ux app/components/Views/Settings @MetaMask/wallet-ux app/components/Views/TermsAndConditions @MetaMask/wallet-ux - app/reducers/experimentalSettings @MetaMask/wallet-ux app/reducers/modals @MetaMask/wallet-ux app/reducers/navigation @MetaMask/wallet-ux