-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix asset-list e2e test #28822
base: develop
Are you sure you want to change the base?
fix: fix asset-list e2e test #28822
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
The error occurs because we attempt to find the TST token created on chain ID 1337, which belongs to the testnet section. However, the unified list excludes tokens from the testnet network, causing the test to fail. To resolve this, I updated the test to include Polygon in the network list, so the TST token is now created on Polygon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tests are passing. Just left one small comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Builds ready [e49bd8b]
Page Load Metrics (1711 ± 48 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Description
fix e2e test for the unified list
Related issues
Fixes:
Manual testing steps
PORTFOLIO_VIEW=1 yarn build:test
PORTFOLIO_VIEW=1 yarn test:e2e:single --browser=chrome test/e2e/tests/multichain/asset-list.spec.ts --debug --leave-running
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist