Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix asset-list e2e test #28822

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

salimtb
Copy link
Contributor

@salimtb salimtb commented Nov 29, 2024

Description

fix e2e test for the unified list

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. run PORTFOLIO_VIEW=1 yarn build:test
  2. Run PORTFOLIO_VIEW=1 yarn test:e2e:single --browser=chrome test/e2e/tests/multichain/asset-list.spec.ts --debug --leave-running

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@salimtb
Copy link
Contributor Author

salimtb commented Nov 29, 2024

The error occurs because we attempt to find the TST token created on chain ID 1337, which belongs to the testnet section. However, the unified list excludes tokens from the testnet network, causing the test to fail. To resolve this, I updated the test to include Polygon in the network list, so the TST token is now created on Polygon.

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tests are passing. Just left one small comment

test/e2e/tests/multichain/asset-list.spec.ts Outdated Show resolved Hide resolved
@salimtb salimtb marked this pull request as ready for review November 29, 2024 18:17
@salimtb salimtb requested a review from a team as a code owner November 29, 2024 18:17
NidhiKJha
NidhiKJha previously approved these changes Nov 29, 2024
Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sahar-fehri
sahar-fehri previously approved these changes Nov 29, 2024
@salimtb salimtb dismissed stale reviews from sahar-fehri and NidhiKJha via e49bd8b November 29, 2024 18:34
@metamaskbot
Copy link
Collaborator

Builds ready [e49bd8b]
Page Load Metrics (1711 ± 48 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31318971633319153
domContentLoaded1524188216859847
load15521904171110048
domInteractive23513094
backgroundConnect76126199
firstReactRender154820105
getState44107792010
initialActions01000
loadScripts1124144312859144
setupStore616721
uiStartup18042106190910048
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 300 Bytes (0.01%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@salimtb salimtb added this pull request to the merge queue Nov 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants