Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update controllers as of core release v244 #28781

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

cryptodev-2s
Copy link
Contributor

@cryptodev-2s cryptodev-2s commented Nov 27, 2024

Description

This PR bumps the following packages:

  • @metamask/user-operation-controller to ^19.0.0
  • @metamask/ens-controller to ^15.0.0
  • @metamask/gas-fee-controller to ^22.0.1
  • @metamask/network-controller to ^22.0.2
  • @metamask/polling-controller to ^12.0.1
  • @metamask/select-network-controller to ^19.0.0

Open in GitHub Codespaces

Related issues

Fixes: #28495

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-user-operatin-controller-19.0.0 branch from a7fc418 to cfe48df Compare November 27, 2024 17:55
Copy link

socket-security bot commented Nov 27, 2024

@cryptodev-2s cryptodev-2s force-pushed the cryptodev2s/bump-user-operatin-controller-19.0.0 branch from cfe48df to 27a1948 Compare November 27, 2024 18:30
@cryptodev-2s
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@metamaskbot metamaskbot requested a review from a team as a code owner November 27, 2024 18:40
@metamaskbot
Copy link
Collaborator

Builds ready [c9178ad]
Page Load Metrics (1648 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1491177216487737
domContentLoaded1443175816228642
load1492177316488039
domInteractive236435136
backgroundConnect96327189
firstReactRender1695533215
getState589252713
initialActions01000
loadScripts1052131512027536
setupStore65812147
uiStartup16612359196118790
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -29.86 KiB (-0.52%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

yarn.lock Outdated Show resolved Hide resolved
@metamaskbot
Copy link
Collaborator

Builds ready [dccd430]
Page Load Metrics (1903 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53327291810375180
domContentLoaded154527101864246118
load156127361903252121
domInteractive247232126
backgroundConnect8102362713
firstReactRender1693322612
getState43195924522
initialActions01000
loadScripts11511713140313967
setupStore617821
uiStartup189029472199258124
Bundle size diffs [🚀 Bundle size reduced!]
  • background: -29.86 KiB (-0.55%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@cryptodev-2s cryptodev-2s changed the title chore: bump @metamask/user-operation-controller to ^19.0.0 chore: update controllers as of core release v244 Nov 28, 2024
@cryptodev-2s
Copy link
Contributor Author

@metamaskbot update-policies

@metamaskbot
Copy link
Collaborator

Policies updated.
👀 Please review the diff for suspicious new powers.

🧠 Learn how: https://lavamoat.github.io/guides/policy-diff/#what-to-look-for-when-reviewing-a-policy-diff

@@ -244,6 +244,7 @@
"@metamask/network-controller@npm:^17.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
"@metamask/network-controller@npm:^19.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
"@metamask/network-controller@npm:^20.0.0": "patch:@metamask/network-controller@npm%3A21.0.0#~/.yarn/patches/@metamask-network-controller-npm-21.0.0-559aa8e395.patch",
"@metamask/network-controller@npm:^21.0.0": "patch:@metamask/network-controller@npm%3A22.0.2#~/.yarn/patches/@metamask-network-controller-npm-22.0.2-6fc65c500a.patch",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still in use by @metamask/ppom-validator

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update metamask/user-operation-controller to version 19.0.0
4 participants