Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add link to pending transaction alert #28721

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

pedronfigueiredo
Copy link
Contributor

@pedronfigueiredo pedronfigueiredo commented Nov 26, 2024

Description

Open in GitHub Codespaces

Related issues

Fixes: #28308

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screenshot 2024-11-26 at 11 05 01

On hover:

Screenshot 2024-11-26 at 11 05 10

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@pedronfigueiredo pedronfigueiredo added the team-confirmations Push issues to confirmations team label Nov 26, 2024
@pedronfigueiredo pedronfigueiredo self-assigned this Nov 26, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [a272f3d]
Page Load Metrics (1859 ± 88 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61022651800335161
domContentLoaded16002254182218790
load16542268185918388
domInteractive246639147
backgroundConnect9207384220
firstReactRender15114322612
getState442601014924
initialActions00000
loadScripts11921746138616077
setupStore6100172311
uiStartup187128982173282135
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.74 KiB (0.02%)
  • common: 170 Bytes (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing link on pending transaction alert
2 participants