refactor: remove global network from transaction controller #28449

matthewwalsh0 · 2024-11-13T21:33:38Z

Description

Upgrade @metamask/transaction-controller to remove all usages of the global network.

Specifically:

Remove deleted constructor options.
Add getGlobalChainId and getGlobalNetworkClientId private methods in MetamaskController.
Remove TRANSACTION_MULTICHAIN environment variable.
Add networkClientId to test data.
Update calls to:
- addTransaction
- estimateGasBuffered
- getNonceLock
- getTransactions
- startIncomingTransactionPolling
- updateIncomingTransactions
- wipeTransactions

Related issues

Fixes: #3499

Manual testing steps

Full regression of all transaction flows.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Remove multichain flag. Remove getCurrentChainId usage in background.

Fix unit tests. Update Lavamoat policies.

metamaskbot · 2024-11-14T00:36:36Z

Builds ready [cafd321]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1826 ± 57 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	386	2142	1765	343	165
		domContentLoaded	1591	2126	1797	114	55
		load	1609	2142	1826	119	57
		domInteractive	17	104	47	22	10
		backgroundConnect	9	68	31	19	9
		firstReactRender	55	117	96	14	7
		getState	5	53	12	10	5
		initialActions	0	0	0	0	0
		loadScripts	1153	1532	1328	95	46
		setupStore	6	59	17	20	9
		uiStartup	1788	2350	2039	127	61

Bundle size diffs [🚀 Bundle size reduced!]

background: -241 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -2.73 KiB (-0.03%)

metamaskbot · 2024-11-16T00:29:52Z

Builds ready [8c6efbf]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2015 ± 103 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	509	2613	1960	407	196
		domContentLoaded	1668	2444	1979	202	97
		load	1679	2495	2015	215	103
		domInteractive	20	95	53	20	10
		backgroundConnect	7	99	36	30	14
		firstReactRender	52	298	122	51	25
		getState	4	97	18	23	11
		initialActions	0	1	0	0	0
		loadScripts	1205	1736	1431	149	71
		setupStore	6	88	22	23	11
		uiStartup	1882	3003	2303	306	147

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -254 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 638 Bytes (0.01%)

metamaskbot · 2024-11-19T13:55:23Z

Builds ready [fcd95a7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1981 ± 143 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	321	2761	1781	549	264
		domContentLoaded	1565	2686	1955	291	140
		load	1573	2766	1981	298	143
		domInteractive	15	179	53	35	17
		backgroundConnect	7	86	25	25	12
		firstReactRender	87	174	111	23	11
		getState	4	68	20	22	11
		initialActions	0	1	0	0	0
		loadScripts	1136	2019	1448	237	114
		setupStore	5	59	13	15	7
		uiStartup	1768	3289	2229	374	180

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -254 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 709 Bytes (0.01%)

…obal-network

metamaskbot · 2024-11-26T10:00:01Z

Builds ready [815aaed]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2029 ± 100 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	322	2494	1853	542	260
		domContentLoaded	1635	2421	1999	207	99
		load	1664	2497	2029	208	100
		domInteractive	26	83	49	18	8
		backgroundConnect	11	75	35	22	10
		firstReactRender	17	74	44	22	11
		getState	6	67	29	23	11
		initialActions	0	1	0	0	0
		loadScripts	1183	1875	1481	177	85
		setupStore	6	52	13	13	6
		uiStartup	1903	2720	2277	219	105

Bundle size diffs [🚀 Bundle size reduced!]

background: -278 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: -2.75 KiB (-0.03%)

metamaskbot · 2024-11-26T10:39:01Z

Builds ready [c378718]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1989 ± 147 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	493	3115	1925	447	215
		domContentLoaded	1620	3101	1962	300	144
		load	1638	3110	1989	307	147
		domInteractive	27	96	51	22	11
		backgroundConnect	8	124	26	28	14
		firstReactRender	19	78	43	22	10
		getState	5	51	14	12	6
		initialActions	0	0	0	0	0
		loadScripts	1173	2036	1417	189	91
		setupStore	7	67	27	25	12
		uiStartup	1860	3405	2228	326	156

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -278 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 3.82 KiB (0.05%)

…obal-network

metamaskbot · 2024-11-26T20:51:44Z

Builds ready [7f8ea7d]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1493 ± 23 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	286	1603	1446	271	130
		domContentLoaded	1380	1571	1471	48	23
		load	1392	1583	1493	47	23
		domInteractive	22	70	49	18	8
		backgroundConnect	11	58	25	14	7
		firstReactRender	15	69	32	22	11
		getState	6	49	13	12	6
		initialActions	0	0	0	0	0
		loadScripts	1005	1205	1082	51	25
		setupStore	6	51	13	15	7
		uiStartup	1560	1761	1641	51	25

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -278 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 709 Bytes (0.01%)

…obal-network

socket-security · 2024-11-29T13:34:10Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	`0`	2.26 MB	danfinlay, gudahtt, kumavis, ...6 more

🚮 Removed packages: npm/@metamask/[email protected]

View full report↗︎

metamaskbot · 2024-11-29T14:07:01Z

Builds ready [96ce747]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2045 ± 128 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	280	2619	1874	584	280
		domContentLoaded	1531	2606	2021	269	129
		load	1539	2617	2045	266	128
		domInteractive	26	98	44	19	9
		backgroundConnect	8	88	29	23	11
		firstReactRender	15	62	25	12	6
		getState	47	142	101	21	10
		initialActions	0	0	0	0	0
		loadScripts	1126	2179	1543	243	116
		setupStore	6	55	13	11	5
		uiStartup	1759	2839	2326	305	147

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: -159 Bytes (-0.00%)
ui: 0 Bytes (0.00%)
common: 709 Bytes (0.01%)

Use preview build

f77045d

Remove multichain flag. Remove getCurrentChainId usage in background.

metamaskbot added the team-confirmations Push issues to confirmations team label Nov 13, 2024

matthewwalsh0 added 2 commits November 13, 2024 22:25

Fix linting

5ca3702

Fix unit tests. Update Lavamoat policies.

Fix nonce lock call

cafd321

matthewwalsh0 added 3 commits November 14, 2024 00:40

Remove debug logs

defa2e5

Restart incoming transaction polling on network change

0b5ce7b

Update Lavamoat policies

8c6efbf

Update MMI getTransactions usage

fcd95a7

matthewwalsh0 mentioned this pull request Nov 19, 2024

refactor: remove global network from transaction controller MetaMask/core#4920

Merged

4 tasks

matthewwalsh0 marked this pull request as ready for review November 19, 2024 13:44

matthewwalsh0 requested review from a team as code owners November 19, 2024 13:44

sleepytanya added the QA Passed label Nov 21, 2024

jpuri previously approved these changes Nov 21, 2024

View reviewed changes

pedronfigueiredo previously approved these changes Nov 21, 2024

View reviewed changes

Merge branch 'develop' into refactor/transaction-controller-remove-gl…

815aaed

…obal-network

matthewwalsh0 dismissed stale reviews from pedronfigueiredo and jpuri via 815aaed November 26, 2024 09:21

Update preview build

c378718

matthewwalsh0 added 3 commits November 26, 2024 18:31

Update version

856ae22

Merge branch 'develop' into refactor/transaction-controller-remove-gl…

bb8c668

…obal-network

Fix linting

7f8ea7d

Merge branch 'develop' into refactor/transaction-controller-remove-gl…

96ce747

…obal-network

matthewwalsh0 requested review from pedronfigueiredo and jpuri November 29, 2024 14:16

matthewwalsh0 enabled auto-merge November 29, 2024 14:16

pedronfigueiredo approved these changes Nov 29, 2024

View reviewed changes

matthewwalsh0 requested review from OGPoyraz and vinistevam November 29, 2024 15:11

OGPoyraz approved these changes Nov 29, 2024

View reviewed changes

matthewwalsh0 added this pull request to the merge queue Nov 29, 2024

Merged via the queue into develop with commit 7d252e9 Nov 29, 2024
75 checks passed

matthewwalsh0 deleted the refactor/transaction-controller-remove-global-network branch November 29, 2024 16:48

github-actions bot locked and limited conversation to collaborators Nov 29, 2024

metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Nov 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove global network from transaction controller #28449

refactor: remove global network from transaction controller #28449

matthewwalsh0 commented Nov 13, 2024 •

edited

Loading

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

socket-security bot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

refactor: remove global network from transaction controller #28449

refactor: remove global network from transaction controller #28449

Conversation

matthewwalsh0 commented Nov 13, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

metamaskbot commented Nov 14, 2024

metamaskbot commented Nov 16, 2024

metamaskbot commented Nov 19, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

metamaskbot commented Nov 26, 2024

socket-security bot commented Nov 29, 2024

metamaskbot commented Nov 29, 2024

matthewwalsh0 commented Nov 13, 2024 •

edited

Loading