-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New BlockaidBannerAlert component #20051
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [2d87fdd]
Page Load Metrics (1640 ± 47 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #20051 +/- ##
===========================================
+ Coverage 69.35% 69.36% +0.01%
===========================================
Files 986 987 +1
Lines 37265 37285 +20
Branches 10002 10011 +9
===========================================
+ Hits 25843 25862 +19
- Misses 11422 11423 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI LGTM!
- Checked storybook build in PR
78c0c17
to
0e151d5
Compare
b967756
to
99333ba
Compare
ui/components/app/security-provider-banner-alert/blockaid-banner-alert/blockaid-banner-alert.js
Outdated
Show resolved
Hide resolved
The base branch was changed.
99333ba
to
3c1c948
Compare
Builds ready [38d603f]
Page Load Metrics (1744 ± 83 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Explanation
Fixes: #19257
Blocked by: #19825
Screenshots/Screencaps
Storybook
Tests
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.