-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving RESIZE
constant to textarea component folder
#19240
Moving RESIZE
constant to textarea component folder
#19240
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report
@@ Coverage Diff @@
## develop #19240 +/- ##
===========================================
- Coverage 70.30% 70.30% -0.01%
===========================================
Files 960 961 +1
Lines 36689 36689
Branches 9543 9543
===========================================
- Hits 25793 25791 -2
- Misses 10896 10898 +2
|
hey @georgewrmarshall, could you please review this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice work thanks for your contribution @dhruvv173 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Explanation
RESIZE
constant to textarea component folder #19233Moved
RESIZE
constant to textarea component foldermetamask-extension\ui\components\ui\textarea\textarea.constants.js
and made changesI also replaced the deprecated
BLOCK_SIZES
constant withBlockSize
enumTo assist the reviewers in verifying that no visual changes have occurred after implementing the changes, I have attached the before and after screenshots below.
Screenshots/Screencaps
Before
After
Manual Testing Steps
yarn jest ui/components/ui/textarea
passed 8 testsPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.