Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ENS resolving implementation to match what is defined in EIP-1577 #5742

Closed
decanus opened this issue Nov 13, 2018 · 16 comments
Closed

Comments

@decanus
Copy link

decanus commented Nov 13, 2018

What problem are you trying to solve?

Name resolution is done using the content and multihash fields right now, to try and find a better system @Arachnid and I created EIP-1577 that allows for a better representation of network and content addresses.

Describe the solution you'd like

Implement resolution using the new multiaddr field when available.

@decanus
Copy link
Author

decanus commented Nov 13, 2018

There will be changes made to the EIP so implementation should be paused.

@decanus
Copy link
Author

decanus commented Nov 19, 2018

The EIP has been updated and should be good to go: https://eips.ethereum.org/EIPS/eip-1577

@danfinlay
Copy link
Contributor

Pinging @PhyrexTsai in case he has bandwidth for this.

@bitpshr bitpshr self-assigned this Nov 29, 2018
@decanus
Copy link
Author

decanus commented Dec 21, 2018

@danfinlay @bitpshr probably best to put this on pause, as we expect to update the spec again soon.

@decanus
Copy link
Author

decanus commented Jan 10, 2019

@danfinlay The EIP has been updated, work should be able to start on it now. https://eips.ethereum.org/EIPS/eip-1577

@Platinumwrist
Copy link

Platinumwrist commented Jan 11, 2019 via email

@bdresser
Copy link
Contributor

@Platinumwrist could you share your UI and background logs on issue #4894 to help us debug. This issue is for something entirely different.

Instructions how to find those logs are here.

@pldespaigne
Copy link
Contributor

Hi ! I have wirtten a small JS lib to implement EIP1577 ! @decanus and the ENS team have used it for the ENS Manager dApp (issue), so I think it could also help in Metamask :)
Also it would be an honnor for me to contribute !

@danfinlay
Copy link
Contributor

@pldespaigne that's fantastic! We would be incredibly grateful for the contribution, we want our ENS support to reflect the latest standard. Please let us know if you have any questions!

@pldespaigne
Copy link
Contributor

OK I will be working on it 😀 ! Can you help me to find my way through the metamask codebase ?

@danfinlay
Copy link
Contributor

I believe our current implementation is in this folder:
https://github.com/MetaMask/metamask-extension/tree/develop/app/scripts/lib/ens-ipfs

I was just made aware of this library, which may be useful for allowing us to resolve a variety of decentralized name services, although I need to look into it more (can it use our user's configured blockchain provider?)
https://github.com/unstoppabledomains/namicorn

@Arachnid
Copy link

namicorn looks okay, but I'm not sure of its value: The format of its returned data seems to depend on the provider, and it doesn't attempt to encode or decode the content hash data at all. I'm not sure it would save you any time over just using our libraries (or calling the contracts) directly.

@pldespaigne
Copy link
Contributor

Work in progress ;)

@pldespaigne
Copy link
Contributor

ping @danfinlay @kumavis @decanus @Arachnid work done ✔️
review requested here

@pldespaigne
Copy link
Contributor

Guys ? Is there anybody to review my PR ?
@danfinlay @kumavis @bdresser

tmashuang added a commit that referenced this issue May 30, 2019
…ver_to_eip_1577

✔️ Issue #5742 update ens resolver to eip 1577
@bdresser
Copy link
Contributor

bdresser commented Jun 5, 2019

Closed in #6402

@bdresser bdresser closed this as completed Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants