-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: has_marketing_consent flag on metametrics #28795
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Data collection for marketing works fine. But when I click on Participate in MetaMetrics toggle, it doesn't work
https://github.com/user-attachments/assets/9f41e1e0-35f2-460b-8f4b-0b2e11fe57b9
Builds ready [7e9a788]
Page Load Metrics (1803 ± 58 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @jonybur, these changes should have been included on 12.9.0. Please confirm. |
@vpintorico these changes should go in 12.9.0. If they didn't make release cut it's ok to include in 12.10.0 |
Description
Sends the correct value for the
has_marketing_consent
flag on trackEvent.Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3699
Manual testing steps
true
valueScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist