Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: has_marketing_consent flag on metametrics #28795

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: has_marketing_consent flag on metametrics #28795

merged 1 commit into from
Nov 29, 2024

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Nov 28, 2024

Description

Sends the correct value for the has_marketing_consent flag on trackEvent.

Open in GitHub Codespaces

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/3699

Manual testing steps

  1. Go to Security settings
  2. Enable the marketing consent
  3. Check that the trackEvent on metametrics is passing a true value
  4. Check same condition when triggering it off

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner November 28, 2024 17:01
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data collection for marketing works fine. But when I click on Participate in MetaMetrics toggle, it doesn't work
https://github.com/user-attachments/assets/9f41e1e0-35f2-460b-8f4b-0b2e11fe57b9

@metamaskbot
Copy link
Collaborator

Builds ready [7e9a788]
Page Load Metrics (1803 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint44919941739320153
domContentLoaded14591946177010952
load14701998180312058
domInteractive247434115
backgroundConnect768342211
firstReactRender155623126
getState4710881199
initialActions01000
loadScripts10551507134110651
setupStore65111115
uiStartup16732245203413464
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 27 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NidhiKJha NidhiKJha added this pull request to the merge queue Nov 29, 2024
Merged via the queue into develop with commit 099a07b Nov 29, 2024
84 checks passed
@NidhiKJha NidhiKJha deleted the fix-3699 branch November 29, 2024 00:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2024
@metamaskbot metamaskbot added the release-12.10.0 Issue or pull request that will be included in release 12.10.0 label Nov 29, 2024
@vpintorico vpintorico added release-12.9.0 Issue or pull request that will be included in release 12.9.0 and removed release-12.10.0 Issue or pull request that will be included in release 12.10.0 labels Nov 29, 2024
@vpintorico
Copy link

Hi @jonybur, these changes should have been included on 12.9.0. Please confirm.

@hesterbruikman
Copy link

@vpintorico these changes should go in 12.9.0. If they didn't make release cut it's ok to include in 12.10.0

cc @jonybur @NidhiKJha

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-12.9.0 Issue or pull request that will be included in release 12.9.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants