Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkController: Remove setActive option from upsertNetworkConfiguration #1259

Closed
mcmire opened this issue Apr 22, 2023 · 1 comment
Closed

NetworkController: Remove setActive option from upsertNetworkConfiguration #1259

mcmire opened this issue Apr 22, 2023 · 1 comment
Labels
team-wallet-framework

Comments

@mcmire
Copy link
Contributor

mcmire commented Apr 22, 2023

There are too many methods that can be used to switch networks, and as a result we have a LOT of tests for NetworkController. It is not difficult for consumers to call setActiveNetwork after calling upsertNetworkConfiguration if they wish to switch to a newly added or updated network. Therefore to minimize the test suite, we should remove this option from upsertNetworkConfiguration.
@Gudahtt
Copy link
Member

Gudahtt commented Oct 1, 2024

This is obsolete as of #4286, which removed upsertNetworkConfiguration

@Gudahtt Gudahtt closed this as completed Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mcmire @desi @Gudahtt