-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output too noisy, particularly for monorepos #95
Labels
Comments
For a monorepo, it would be great if the dry run summary looked like this:
For a polyrepo, the output could be simplified slightly:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As an NPM admin, it is my job to review the dry-run output for a project in order to approve a release. However, the output for this action is too noisy. This is mainly due to the fact that
+x
is still enabled, but the output is also a bit disorganized. This is not a huge deal for libraries, but for monorepos, which could contain many packages, it makes review unnecessarily difficult. One must have knowledge of what is important and what is not, and details could be missed.Ideally, the output should make it very clear what actions are about to be performed (or not performed) and which packages are being published and which are not. And all actions should be grouped by package if possible instead of being divided up. Finally, the output should provide instructions to assist the reviewer.
Because this action has additional steps after the "Dry Run Publish" step, perhaps it makes more sense to provide a step at the very end which summarizes what happened instead of trying to clean up
scripts/publish.sh
orscripts/report.sh
. Then we would ask people to look at this step instead of "Dry Run Publish" during review. This would allow us to create the output we want.The text was updated successfully, but these errors were encountered: