Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look to efficient processing of files #46

Open
MatthewHambley opened this issue Mar 24, 2022 · 0 comments
Open

Look to efficient processing of files #46

MatthewHambley opened this issue Mar 24, 2022 · 0 comments
Labels
discussion This issue needs further discussion enhancement New feature or request

Comments

@MatthewHambley
Copy link
Collaborator

At the moment each (tree) rule is passed the parse tree which it then pokes about in for its own purposes.

The concern is that this may become a performance issue as the number of rules increases. Is there a way to implement the rules as tree visitors. the tree would then be traversed in its entirety but only once with each rule doing what it needs to as it goes past.

On the other hand would this be complex and unwieldy with much too much state having to be maintained to allow the rules to reference back to previously seen nodes on the tree?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion This issue needs further discussion enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant