Changes required for addition of oops::Variable. Targeted merge: 11/06/24
#210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mo-joshuacolclough
requested review from
DJDavies2,
ctgh,
mikecooke77 and
MayeulDestouches
mo-joshuacolclough
changed the title
oops::Variable. Targeted merge: *11/06/24*oops::Variable. Targeted merge: 11/06/24
MayeulDestouches
approved these changes
Jun 7, 2024
DJDavies2
approved these changes
Jun 7, 2024
mikecooke77
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
I agree with @MayeulDestouches that this can go in without the dependency. Could you add the ready to merge flag and I will merge.
|
Thanks all :) |
|
@mikecooke77 I think deleting this branch has caused the UKMO OOPS CI to fail. I am restoring it to try and get them a green tick. Something for us to consider now we have build-groups working. https://github.com/JCSDA-internal/oops/actions/runs/9453134878/job/26037844053 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description.
For https://github.com/JCSDA-internal/oops/pull/2646.
Fixes a segfault with the latest OOPS update. Changes oops_variables -> obs_variables such as is seen in the IODA change: https://github.com/JCSDA-internal/ioda/pull/1283/files.
Requires testing with all other
feature/use_variablebranches.Issue
Resolves #209
Dependencies
Targeted merge date: 11/06/24.
Impact
Fixes usage of opsinputs downstream, with ops-um-jedi and lfric-lite-jedi atms_hofx tests.