Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor client.py discover_catalog_entry #261

Open
visch opened this issue Oct 13, 2023 · 0 comments
Open

Refactor client.py discover_catalog_entry #261

visch opened this issue Oct 13, 2023 · 0 comments

Comments

@visch
Copy link
Member

visch commented Oct 13, 2023 

          Can we get rid of this whole function override and just override the setter for `replication_key` if LOG_BASED then `_sdc_lsn` , also we should mention this in the docs (that the replication key is automatically set to _sdc_lsn which is the lsn number from (link to page)

Originally posted by @visch in #249 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
MeltanoLabs Overview
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@visch