Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added null check for lastUnitMember #6212

Merged
merged 1 commit into from
Nov 23, 2024
Merged

Conversation

DM0000
Copy link
Contributor

@DM0000 DM0000 commented Nov 22, 2024

closes #6211.

Check to see if lastUnit.next() is null before trying to setUnitNumber doing entityUpdate.
Fixed crash when removing protos in provided mul and was able to deploy force

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.18%. Comparing base (a28fd13) to head (204c1f5).
Report is 49 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6212      +/-   ##
============================================
+ Coverage     29.09%   29.18%   +0.08%     
+ Complexity    13981    13980       -1     
============================================
  Files          2647     2628      -19     
  Lines        267373   266566     -807     
  Branches      47650    47577      -73     
============================================
- Hits          77793    77789       -4     
+ Misses       185696   184896     -800     
+ Partials       3884     3881       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@HammerGS HammerGS merged commit d602cee into MegaMek:master Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NPE - megamek.common.Entity.setUnitNumber(short)
2 participants