Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless rows of January 1st #31

Open
DestructionOfPlanetJupiter opened this issue Dec 26, 2018 · 9 comments
Open

Endless rows of January 1st #31

DestructionOfPlanetJupiter opened this issue Dec 26, 2018 · 9 comments

Comments

@DestructionOfPlanetJupiter

There still appears to be something off with the switch from one year to the next. I have a Sailfish one and since I have updated the stations a couple of days ago, I have an endless(?) row of January 1st entries. At least there are entries now unlike in previous years, but there appears to be still an error in your app. I can provide a screenshot if necessary. Also the app takes quite a while to start with these amount of entries.

The app version is 1.1.20. I can provide a screenshot if necessary.

@Olf0
Copy link
Member

Olf0 commented Dec 27, 2018

Well, for me the usual bug occurs this year as every turn of the year:
No data downloaded for dates after the 31st of December (until it is the 1st of January, at least in previous years).

@DestructionOfPlanetJupiter, supposedly your new station settings made a difference here.

@vasvlad, I also hoped for this bug being fixed, as it was originally reported years ago, IIRC.
But obviously nobody (including me) took the effort to file it here (at least I have not found it).

P.S.: So I just filed it as issue #32.

@DestructionOfPlanetJupiter
Copy link
Author

@Olf0 Yes, I had the problem you have outlined last year as well.
The app runs on a Jolla 1 and on Sailfish 3.0.0.8.

@DestructionOfPlanetJupiter
Copy link
Author

DestructionOfPlanetJupiter commented Jan 1, 2019

Update in the new year provides empty data rows.

... great ...

edit:
New enties reveal proper data sets ..., so all had to be added again. Which is rather unconvenient. Furthermore, I do not know the weather stations, so I have to set up all again anew ... should a further update on the 2nd January should proof to be insufficient

@Olf0
Copy link
Member

Olf0 commented Jan 2, 2019

@DestructionOfPlanetJupiter,

Update in the new year provides empty data rows.

No, at least not for me and as every year: Weather data was completely updated (7 days forecast) by the first scheduled update in the new year.

edit:
New enties reveal proper data sets ..., so all had to be added again. Which is rather unconvenient. Furthermore, I do not know the weather stations, so I have to set up all again anew ... should a further update on the 2nd January should proof to be insufficient

I guess you just should have been patient.

@vasvlad
Copy link
Member

vasvlad commented Dec 24, 2019

Fixed

@vasvlad vasvlad closed this as completed Dec 24, 2019
@DestructionOfPlanetJupiter
Copy link
Author

Problem still exists. Version 1.1.23

@vasvlad
Copy link
Member

vasvlad commented Dec 29, 2019

Problem still exists. Version 1.1.23

Try version 1.1.24
https://openrepos.net/content/vasvlad/meecast-sailfishos

@Olf0
Copy link
Member

Olf0 commented Dec 31, 2019

@vasvlad, rereading this I realise we are bad bug reporters.
As this can only be observed on the last six days before each turn of the year, my intention is to create at least a proper bug report this year.

My testing environment:

  • MeeCast 1.1.23-8 under SailfishOS 2.2.1 on a Jolla 1
  • MeeCast 1.1.24-1 under SailfishOS 3.2.1 on an Xperia X

Both have weather data for the same three locations subscribed from Weather.com (only).


Side note:
IIRC, earlier (i.e., years ago), MeeCast did show N/A (not available) when Weather.com was used as data provider, in the Events View (for the currently selected location) and each location main page in MeeCast for any date after December 31. At the turn of the year (i.e., on January 1st) this "automatically resolved itself" only to reappear again on the next December 25 (because it is 7 days before January 1st).
This is definitely fixed (AFAIR at the beginning of 2018), i.e. the weather data from Weather.com is correctly retrieved now for dates in the next year.


What I observe now (since retrieving the data from Weather.com has been fixed, i.e. at the end of 2019 and IIRC also at the end of 2018) is merely an issue how MeeCast displays the weather data for the last day of the seven days forecast in each location main page:
The line with the information for the last day of the forecast is displayed 23 times, followed by approximately the same amount (~ 23) of blank lines.

Screenshots of this issue:

  • MeeCast 1.1.23-8 under SailfishOS 2.2.1 on a Jolla 1 in portrait orientation
    • The first six days are displayed fine
      Screenshot_20191231_001
    • The last day is displayed 23 times
      Screenshot_20191231_002
    • Followed by many blank lines
      Screenshot_20191231_003
      Screenshot_20191231_004
  • MeeCast 1.1.24-1 under SailfishOS 3.2.1 on an Xperia X in landscape orientation
    • The first six days are displayed fine
      Screenshot_20191231_001
    • The last day is displayed 23 times
      Screenshot_20191231_002
    • Followed by many blank lines
      Screenshot_20191231_003

The only difference between MeeCast 1.1.23-8 and 1.1.24-1 in this regard seems to be:
When I select Refresh in the top pulley menu, v1.1.24-1 suddenly displays everything fine (i.e., last day of the forecast only once and no blank lines), until I close and reopen MeeCast!
In contrast to that a Refresh in v1.1.23-8 does not rectify this display issue.


Hence this issue is basically fixed (as seen after triggering Refresh) but unfortunately still exists when MeeCast 1.1.24-1 is freshly started!
Thus please reopen this issue.

@vasvlad vasvlad reopened this Jan 1, 2020
@DestructionOfPlanetJupiter
Copy link
Author

harbour-meecast-1.1.24-1.armv7hl.rpm has another issue, the version number in Info is wrong. It says: 1.1.22, which is not something we have installed. Maybe you fix this thing along the way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants