-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move misc. "easy" scripts to the framework #87
Comments
I wrote that a while ago to solve a short-term problem (coverage of error cases and comparing that with what the specification draft says, to identify missing cases in the specification and missing coverage in our tests). I got it merged because it seemed like it could be a useful way to measure this aspect of test coverage, but I don't think we've made any use of it since then. So we could remove it and the corresponding code, if that's easier than moving it to the framework. Today I would use the PSA wrapper generator framework for this, and I even have code to do that (also logging parameters, not just return values) in Mbed-TLS/mbedtls#8559 (I used that partly to validate the PSA wrapper generator framework and partly because I needed to log the coverage of parameters).
It's very tightly coupled with
In principle this could have branch-specific code. But right now I can't think of anything branch-specific that I'd want to add even if I had plenty of spare time. It's mostly about checking that we're catching the kinds of failure we expect to catch from the test framework as well as from environment features such as sanitizers. So I think it belongs together with |
My main question about programs is are we ready to have C executable programs (as opposed to libraries / object files) in the framework, in terms of how our build system(s) work? Cc @ronald-cron-arm Other than that, I'm also inclined to have them in the framework. But if that's not easy, we might want to post-pone it (or at least split it to a separate task). |
We have not done this so far thus we definitely need a specific task for that. |
Move the following files to the framework:
These are the scripts that are:
To be discussed: should we also move
programs/test/zeroize.c
andprograms/test/metatest.c
?Note: as usual for this EPIC, the work is only to move the files to the framework repo and adapt the paths everywhere they're used in mbedtls 3.6 and development. If further changes are needed to adapt to tf-psa-crypto, they're out of scope and will be covered by separate tasks.
The text was updated successfully, but these errors were encountered: