Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generated file checks #50

Open
2 tasks
ronald-cron-arm opened this issue Sep 22, 2023 · 3 comments · Fixed by Mbed-TLS/mbedtls#8523 · May be fixed by #91
Open
2 tasks

Add generated file checks #50

ronald-cron-arm opened this issue Sep 22, 2023 · 3 comments · Fixed by Mbed-TLS/mbedtls#8523 · May be fixed by #91
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)

Comments

@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Sep 22, 2023

Add generated file checks

  • Adapt tests/scripts/check-generated-files.sh to work for both mbedtls and TF-PSA-Crypto. Note: TF-PSA-Crypto has less generated files: no error.c, version_features.c, ssl_debug_helpers_generated.c, visualc/VS2013 ... Keep check of all files when called in the context of mbedtls for the time being.
  • Add component_check_generated_files all.sh component in tf-psa-crypto/tests/scripts/components-basic-checks.sh.

Note: no make build system, CMake should be used instead

Depends on: Mbed-TLS/mbedtls#9720.

DOD: Same support for generated file checking in TF-PSA-Crypto as in mbedtls.

@ronald-cron-arm
Copy link
Contributor Author

#91 remains to be reviewed and merged for this issue to be completed.

@gilles-peskine-arm
Copy link

Note that in principle, check-generated-files.sh is obsolete: we now solely rely on make generated_files in the CI. We only use check-generated-files.sh for three things:

  • To determine which files are generated, in code_style.py. That's a hack, and having an official make list_generated_files would be better.
  • In all.sh, but that's only to (partially) check the consistency between the different ways to generate files. If we only have CMake then we don't need that consistency check any longer.
  • Sometimes, when preparing release branches, to check that we have up-to-date generated files. But we could rely on make generated_files instead.

CMake has no generated_files target, but it should — it's just that nobody has implemented it yet.

We do however need make_generated_files.bat. That's needed for the CI on Windows (invoked from windows_testing.py).

@gilles-peskine-arm
Copy link

The new Coverity push script from Mbed-TLS/mbedtls-test#165 relies on check-generated-files -u. If we change the way to ensure that generated files are present, we'll need to remember to update the Coverity push script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size-s Estimated task size: small (~2d)
Projects
Status: TF-PSA-Crypto all.sh components
3 participants