Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update favicon #7

Open
Rio517 opened this issue Oct 8, 2015 · 2 comments
Open

Update favicon #7

Rio517 opened this issue Oct 8, 2015 · 2 comments

Comments

@Rio517
Copy link

Rio517 commented Oct 8, 2015

Update favicon to standard mayday.us favicon https://mayday.us/favicon.ico
@steveslotnick
Copy link

This should be easy, but unfortunately there is some weird bug when using sails.js and backbone together. The commit that got this working in the core midas repo says "FINALLY got Backbone and Require working with Sails." https://github.com/18F/midas/commit/ada003bd0fefba19d34c032b1d5a2b809f89d0bc

@Rio517
Copy link
Author

Rio517 commented Oct 14, 2015

It looks like midas is just relying on the browser grabbing the default /favicon.ico. I bet if we add an explicit link to our favicon on mayday.us in the layout, it should work in most browsers.

https://github.com/MayOneUS/midas/blob/master/views/layout.ejs#L5

<link rel="icon" href="https://mayday.us/favicon.ico" type="image/x-icon" />

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rio517 @steveslotnick