Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation Previews – find combinable measures/zones #14

Open
nikobeer opened this issue Dec 5, 2022 · 0 comments
Open

Annotation Previews – find combinable measures/zones #14

nikobeer opened this issue Dec 5, 2022 · 0 comments
Assignees
Labels

Comments

@nikobeer
Copy link
Member

nikobeer commented Dec 5, 2022

What do we have?

  • 6 consecutive measures on the same source page as participants of an annotation with a line/system break after measure 3
  • zone of measure 4 does not overlap with zone of measure 1 (because measure 1 is "more right" on the page than measure 4)
  • but zones of measures 5 and 6 do overlap with the (above) measure zones prior to the line/system break (zones of measures 1 to 3)

What do we want?
Either:

  • one calculated preview area from measure 1 to 6 (seems complicated to evaluate and calculate)
  • two calculated preview areas – 1. from 1 to 3 and 2. from 4 to 6. (preferred)

What do we get?
Edirom or better getAnnotationPreviews.xql calculates two preview areas that contain redundant measures/zones:

  1. M 1 to 3 + M 5 to 6
  2. M 4 to 6

Where can we see this bug in action?
rwa_annot_28031 or better: ask @nikobeer because content is not publicly available yet.

Where does it happen in the code?
getAnnotationPreviews.xql functions local:getCombinations/local:compareZones

What could be a possible solution?
Maybe we should stop evaluation of combinations at position where local:compareZones returns "false" and start over by resetting position[where we stopped +1] to position[1] and shrink the amount of measures to compare ($total) to the amount of remaining measures after position[where we stopped + 1]?

Or: Further (re)evaluate if the resulting aggregated preview areas are overlapping and build an even bigger preview area and so on. Until there is one preview area left for each page…

@riedde and @bwbohl: I think that this is little bit serious, because it could lead to some irritating preview presentations…

@nikobeer nikobeer added the bug label Dec 5, 2022
@nikobeer nikobeer self-assigned this Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant