Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Newer API bug #1

Open
joaocruz04 opened this issue Sep 26, 2013 · 2 comments
Open

Newer API bug #1

joaocruz04 opened this issue Sep 26, 2013 · 2 comments

Comments

@joaocruz04
Copy link

Hi,
I recently updated my support.v4 (rev. 18) library and used an SGS3 to run an application using your lib.

I found out that in this particular case the background image was showing incorrectly.

I found the bug: the getWidth() and getHeight() are returning different values comparing to the canvas.getWidth() and canvas.getHeight() (I don't know why yet but...)

My fix was to change the destination rect in the onDraw to:
dst.set((int) (getScrollX()), 0,
(int) (getScrollX() + getWidth()), getHeight());

this fixed the bug on the SGS3 and all previous Android versions and device screens were running OK too.

Hope you take a look.

@MatthieuLJ
Copy link
Owner

My only concern is if this is something that is different for some reason between different platforms or different versions of Android. I'll try to look up some information about this. Thanks for pointing this out!

@kbala-ami
Copy link

hey, when you set the page by setCurrentItem(2, true), then the page scrolls bit fast, can you suggest how to reduce the scroll speed?

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants