Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LASSIS-PDFT Cleanup #120

Closed
JangidBhavnesh opened this issue Aug 17, 2024 · 1 comment
Closed

LASSIS-PDFT Cleanup #120

JangidBhavnesh opened this issue Aug 17, 2024 · 1 comment
Labels
code hygiene Nothing is actually wrong, but the code should be "cleaned up" to elegant conventions

Comments

@JangidBhavnesh
Copy link
Contributor

LASSIS-PDFT is written as the child class of MC-PDFT. Because of that all the functions which are defined for MCPDFT are inherited. These functions won't work for LASSIS. So have to write the warning msgs, or to point towards the corresponding LASSIS functions.
@MatthewRHermes MatthewRHermes added the code hygiene Nothing is actually wrong, but the code should be "cleaned up" to elegant conventions label Aug 19, 2024
@JangidBhavnesh JangidBhavnesh mentioned this issue Aug 31, 2024
Merged
@JangidBhavnesh
Copy link
Contributor Author

I have addressed this in #121

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code hygiene Nothing is actually wrong, but the code should be "cleaned up" to elegant conventions
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MatthewRHermes @JangidBhavnesh