Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values in turbomoleio vs turbomole #32

Open
davidwaroquiers opened this issue Jan 25, 2023 · 0 comments
Open

Default values in turbomoleio vs turbomole #32

davidwaroquiers opened this issue Jan 25, 2023 · 0 comments

Comments

@davidwaroquiers
Copy link
Member

When Turbomole releases a new version, some of the inputs change their default values. This has an impact on the outputs (usually minor). What should be the procedure in turbomoleio then ? Should we set default directly in turbomoleio but allowing to use Turbomole's default. The advantage is that integration tests should continue to work the exact same way (if the actual implementation in Turbomole did not change). The disadvantage is that when Turbomole developers change a default value, it is probably for a good reason so it might be good to actually use the new default.

This issue arose as a discussion on the "sym_eps" value in #29:

          Do we leave Turbomole's default (i.e. passing "" when it is not set in the parameters) or do we set a turbomoleio default ? The "advantage" of doing it in turbomoleio is that if it changes in Turbomole, the integration tests will continue to work (and the simulations will/should continue to give the same, or at least similar, results). Most probably this is not the only parameter/place where we could have such an option. We could maybe open an issue about this and likely it should also be something to be discussed with the turbomole developers. What do you think ?

Originally posted by @davidwaroquiers in #29 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant